Summary

Add support for writing patches to a file using rbt patch --write.

Review Request #11706 — Created July 6, 2021 and submitted July 27, 2021, 7:19 p.m.

Information

Owner

chipx86

Repository

RBTools

Branch

release-2.0.x

Bugs

Depends On

Blocks

11677

Reviewers

Groups

rbtools

People

Description

rbt patch can now write patches to a local file by passing
--write=<filename>. This works just like --print with a redirect to
a file, but avoids any possibility of unwanted output being written.

This cannot be used along with --print or --revert. Either will exit
early with an error.

This change is based on https://reviews.reviewboard.org/r/11676/ by
André Klitzing, and was updated to remove some legacy handling of diff
content Unicode strings and to rename the option from --file to
--write.

Testing Done

Tested --print, --write, and --print > filename on Python 2 and 3,
with diffs containing Unicode content. In all cases, the file content
was written/outputted correctly and consistently.

Tested that neither --write nor --print could be used with each other
or with --revert.

Commits

Summary	ID
Add support for writing patches to a file using rbt patch --write. `rbt patch` can now write patches to a local file by passing `--write=<filename>`. This works just like `--print` with a redirect to a file, but avoids any possibility of unwanted output being written. This cannot be used along with `--print` or `--revert`. Either will exit early with an error. This change is based on https://reviews.reviewboard.org/r/11676/ by André Klitzing, and was updated to remove some legacy handling of diff content Unicode strings and to rename the option from `--file` to `--write`.	b46df207e34c76e1e435436f1441dd69af5f3114

Summary

Add support for writing patches to a file using rbt patch --write.

`rbt patch` can now write patches to a local file by passing `--write=<filename>`. This works just like `--print` with a redirect to a file, but avoids any possibility of unwanted output being written. This cannot be used along with `--print` or `--revert`. Either will exit early with an error. This change is based on https://reviews.reviewboard.org/r/11676/ by André Klitzing, and was updated to remove some legacy handling of diff content Unicode strings and to rename the option from `--file` to `--write`.

b46df207e34c76e1e435436f1441dd69af5f3114

Issues

Description	From	Last Updated
Thanks! It works for me... but has one issue. $ rbt patch --write=dummy https://reviews.reviewboard.org/r/11706/ ERROR: Unable to find a Review …	misery	July 17, 2021, 7:55 p.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

The issue has been resolved. Show all issues

Thanks! It works for me... but has one issue.

$ rbt patch --write=dummy https://reviews.reviewboard.org/r/11706/
ERROR: Unable to find a Review Board server for this source code tree.

See: /r/11381/

Work-Around

$ rbt patch --write=dummy --server https://reviews.reviewboard.org https://reviews.reviewboard.org/r/11706/

Change Summary:

Fixed using a review request URL as the patch source without passing --server.

Commits:

	Summary	ID
	Add support for writing patches to a file using rbt patch --write. `rbt patch` can now write patches to a local file by passing `--write=<filename>`. This works just like `--print` with a redirect to a file, but avoids any possibility of unwanted output being written. This cannot be used along with `--print` or `--revert`. Either will exit early with an error. This change is based on https://reviews.reviewboard.org/r/11676/ by André Klitzing, and was updated to remove some legacy handling of diff content Unicode strings and to rename the option from `--file` to `--write`.	a5620a5afc648098bbd1da8a0a63dca976642d7b
	Add support for writing patches to a file using rbt patch --write. `rbt patch` can now write patches to a local file by passing `--write=<filename>`. This works just like `--print` with a redirect to a file, but avoids any possibility of unwanted output being written. This cannot be used along with `--print` or `--revert`. Either will exit early with an error. This change is based on https://reviews.reviewboard.org/r/11676/ by André Klitzing, and was updated to remove some legacy handling of diff content Unicode strings and to rename the option from `--file` to `--write`.	b46df207e34c76e1e435436f1441dd69af5f3114

Diff:

Revision 2 (+96 -34)

Show changes

rbtools/commands/patch.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (16bfc54)