Add --file to download the patch

Review Request #11676 — Created June 25, 2021 and discarded

Information

RBTools
master

Reviewers

Add --file to download the patch

Checked that I can download a patch to a file with python3 and python2.

Also that I cannot mix --print, -R and --file together.

Summary ID
Add --file to download the patch
5b677ad64e50a03d63612bcf6ee512cdfb794cbe
Description From Last Updated

This might be better as --write, since --file arguments often mean "Takes in a file" rather than "writing a file." …

chipx86chipx86

I think a better way of handling this would be to generate a stream up-front that'll go to the right …

chipx86chipx86
misery
  1. 
      
  2. branch 2.0?

  3. 
      
chipx86
  1. 
      
  2. rbtools/commands/patch.py (Diff revision 1)
     
     

    This might be better as --write, since --file arguments often mean "Takes in a file" rather than "writing a file." Thoughts?

  3. rbtools/commands/patch.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    I think a better way of handling this would be to generate a stream up-front that'll go to the right place (file handle or output stream) and then just write to that directly, without special-casing at output time.

    It'd need to be tested for Unicode and non-Unicode diff output on Python 2 and 3.

    I have something in mind for this, if you'd like me to take over the change.

    1. Yeah, of course. You can take it over. ????

  4. 
      
chipx86
Review request changed

Status: Discarded

Change Summary:

Replaced with https://reviews.reviewboard.org/r/11706/.

Loading...