Summary

Add --file to download the patch

Review Request #11676 — Created June 25, 2021 and discarded July 6, 2021, 9:28 p.m.

Information

Owner

misery

Repository

RBTools

Branch

master

Bugs

Depends On

Blocks

11677

Reviewers

Groups

rbtools

People

Description

Add --file to download the patch

Testing Done

Checked that I can download a patch to a file with python3 and python2.

Also that I cannot mix --print, -R and --file together.

Commits

Summary	ID
Add --file to download the patch	5b677ad64e50a03d63612bcf6ee512cdfb794cbe

Issues

Description	From	Last Updated
This might be better as --write, since --file arguments often mean "Takes in a file" rather than "writing a file." …	chipx86	June 25, 2021, 8:04 p.m.
I think a better way of handling this would be to generate a stream up-front that'll go to the right …	chipx86	June 25, 2021, 8:04 p.m.

flake8 passed.

JSHint passed.

```
branch 2.0?
```

Fix it!

rbtools/commands/patch.py (Diff revision 1)

An issue was opened. Show all issues

This might be better as --write, since --file arguments often mean "Takes in a file" rather than "writing a file." Thoughts?

rbtools/commands/patch.py (Diff revision 1)

An issue was opened. Show all issues

I think a better way of handling this would be to generate a stream up-front that'll go to the right place (file handle or output stream) and then just write to that directly, without special-casing at output time.

It'd need to be tested for Unicode and non-Unicode diff output on Python 2 and 3.

I have something in mind for this, if you'd like me to take over the change.

misery June 25, 2021, 8:43 p.m.

Yeah, of course. You can take it over. ????

Status: Discarded

Change Summary:

Replaced with https://reviews.reviewboard.org/r/11706/.