Add --file to download the patch
Review Request #11676 — Created June 25, 2021 and discarded
Information | |
---|---|
misery | |
RBTools | |
master | |
11677 | |
Reviewers | |
rbtools | |
Add --file to download the patch
Checked that I can download a patch to a file with python3 and python2.
Also that I cannot mix --print, -R and --file together.
-
-
rbtools/commands/patch.py (Diff revision 1) This might be better as
--write
, since--file
arguments often mean "Takes in a file" rather than "writing a file." Thoughts? -
rbtools/commands/patch.py (Diff revision 1) I think a better way of handling this would be to generate a stream up-front that'll go to the right place (file handle or output stream) and then just write to that directly, without special-casing at output time.
It'd need to be tested for Unicode and non-Unicode diff output on Python 2 and 3.
I have something in mind for this, if you'd like me to take over the change.