Quick fix for refreshing changes for tools

Review Request #11207 — Created Oct. 1, 2020 and updated

jblazusi
ReviewBot
master
4bba6ed...
reviewbot, students
ceciliawei, jace

Updated the ReviewBot ToolResource.
Previously the ToolResource would not correctly update changes made to any
ReviewBot Tools. The previous behavior would allow a ReviewBot tool to be
updated only if there is a change in name/version. However, during
development this can be frustrating, since options are being frequently
revised. To fix this problem, I have changed resource to update the
instance of the tool in the database. This is done regardless of a change
in versioning. This makes the process of creating tools easier, since tool
settings made in the tool are updated each time that the ToolResource
create method is called.

This is difficult to do since there is no test framework setup for
ReviewBot. No real tests were done, only manual testing and a quick
visual inspection.

Description From Last Updated

Looks like the description is wrapping a bit too early. Can you target ~70 (upwards of 75) characters for the ...

ceciliaweiceciliawei
jace
  1. Ship It!
  2. I'll try to get that framework done ASAP. But the change looks good!

  3. 
      
ceciliawei
  1. Looks like the description is wrapping a bit too early. Can you target ~70 (upwards of 75) characters for the wrap point? Helps keep it from appearing really short.

  2. 
      
ceciliawei
  1. 
      
    • Looks like the description is wrapping a bit too early. Can you target ~70 (upwards of 75) characters for the wrap point? Helps keep it from appearing really short.

    • Just to clarify on the visual inspection, did you mean manual testing?

    1. Good catch, Thank you
      I updated the wrapping to be closer to 70-75 characters per line.
      Yes, in this case I did a manual test and visually checked it.

  2. 
      
jblazusi
Review request changed

Description:

~  

Updated the ReviewBot ToolResource.

~   Previously the ToolResource would not correctly update changes
~   made to any ReviewBot Tools. The previous behavior would allow
~   a ReviewBot tool to be updated only if there is a change in
~   name/version. However, during development this can be frustrating,
~   since options are being frequently revised.
~   To fix this problem, I have changed resource to update the instance
~   of the tool in the database. This is done regardless of a change
~   in versioning. This makes the process of creating tools easier,
~   since tool settings made in the tool are updated each time that
  ~

Updated the ReviewBot ToolResource.

  ~ Previously the ToolResource would not correctly update changes made to any
  ~ ReviewBot Tools. The previous behavior would allow a ReviewBot tool to be
  ~ updated only if there is a change in name/version. However, during
  ~ development this can be frustrating, since options are being frequently
  ~ revised. To fix this problem, I have changed resource to update the
  ~ instance of the tool in the database. This is done regardless of a change
  ~ in versioning. This makes the process of creating tools easier, since tool
  ~ settings made in the tool are updated each time that the ToolResource
  ~ create method is called.

-   the ToolResource create method is called.

Testing Done:

~  

This is difficult to do since there is no test framework setup

~   for ReviewBot. No real tests were done, only visual inspection.

  ~

This is difficult to do since there is no test framework setup for

  ~ ReviewBot. No real tests were done, only manual testing and a quick
  + visual inspection.

Loading...