Change tab index on review request page (student project)
Review Request #10848 — Created Jan. 22, 2020 and updated
Information | |
---|---|
LittleGrey | |
Review Board | |
master | |
Reviewers | |
reviewboard | |
The review request page has a weird keyboard behavior. When you
want to tab-navigate, the ordering is strange. Hitting tab
repeatedly will get you to the right-hand column
(review-request-details
), and then to the left-hand
(request-request-main
) column, which seems backwards, and
it takes a while to even get there.I switched the HTML code blocks of these two elements so that
hitting tab will get you to left column -> right column. Also
I modified a few CSS lines to avoid element arrangement
problems (the two columns are not at the same height if I
didn't change the CSS).A demo video is at here.
Click on the top fields, hitting tabs until it gets to the left column and then right column.
Summary | Author |
---|---|
Xiaohui Liu | |
Xiaohui Liu | |
Jay |
Description | From | Last Updated |
---|---|---|
Can you show screenshots of this in both mobile and desktop modes? It's important that mobile doesn't break. You can … |
|

Description: |
|
---|

-
-
reviewboard/static/rb/css/pages/review-request.less (Diff revision 1) According to the style from other blocks, my suggestion could be swithing the order of
width
andposition
in alphabetial order.It doesn't mention in css/less style guide, so I am not sure it will be a correct coding style.

Commits: |
|
||||||||
---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+27 -25) |
Checks run (2 succeeded)

Change Summary:
Make the layout mobile-friendly.
Commits: |
|
||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+30 -30) |
||||||||||||||||||
Added Files: |