Summary

Compare HTTP responses against byte strings.

Review Request #10479 — Created March 31, 2019 and submitted April 10, 2019, 7:55 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

HttpResponse.content is a byte string, and we have a lot of tests
comparing these against Unicode strings. In Python 2, that's not a big
deal, but Python 3 heavily distinguishes between the two.

This change updates all comparisons to check only against byte strings.

Testing Done

Unit tests pass on Python 2.7 and 3.5-3.7 (with other in-progress

changes).

Commits

Summary	ID
Compare HTTP responses against byte strings. `HttpResponse.content` is a byte string, and we have a lot of tests comparing these against Unicode strings. In Python 2, that's not a big deal, but Python 3 heavily distinguishes between the two. This change updates all comparisons to check only against byte strings.	0e1193e96a64066cd5d694666fe5640e845dd4e9

Issues

Description	From	Last Updated
E501 line too long (80 > 79 characters)	reviewbot	March 31, 2019, 7:38 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/tests/test_reviews_diff_fragment_view.py (Diff revision 1)
Show all issues
```
E501 line too long (80 > 79 characters)
```

Change Summary:

Fixed a line length issue.

Commits:

	Summary	ID
	Compare HTTP responses against byte strings. `HttpResponse.content` is a byte string, and we have a lot of tests comparing these against Unicode strings. In Python 2, that's not a big deal, but Python 3 heavily distinguishes between the two. This change updates all comparisons to check only against byte strings.	ef28ab2ea72ef62836d65cd7fa8528e253f3c441
	Compare HTTP responses against byte strings. `HttpResponse.content` is a byte string, and we have a lot of tests comparing these against Unicode strings. In Python 2, that's not a big deal, but Python 3 heavily distinguishes between the two. This change updates all comparisons to check only against byte strings.	0e1193e96a64066cd5d694666fe5640e845dd4e9

Diff:

Revision 2 (+46 -44)

Show changes

	reviewboard/accounts/tests/test_check_login_required_view_mixin.py
	reviewboard/accounts/tests/test_login_required_view_mixin.py
	reviewboard/accounts/tests/test_user_profile_required_view_mixin.py
	reviewboard/diffviewer/tests/test_diff_renderer.py
	reviewboard/reviews/tests/test_reviews_diff_fragment_view.py
	reviewboard/search/tests.py
	reviewboard/site/tests.py
	reviewboard/webapi/tests/test_draft_patched_file.py
	2 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (d831c02)