Compare HTTP responses against byte strings.

Review Request #10479 — Created March 31, 2019 and submitted

chipx86
Review Board
release-4.0.x
reviewboard

HttpResponse.content is a byte string, and we have a lot of tests
comparing these against Unicode strings. In Python 2, that's not a big
deal, but Python 3 heavily distinguishes between the two.

This change updates all comparisons to check only against byte strings.

Unit tests pass on Python 2.7 and 3.5-3.7 (with other in-progress
changes).

Summary
Compare HTTP responses against byte strings.
Description From Last Updated

E501 line too long (80 > 79 characters)

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (d831c02)
Loading...