Compare HTTP responses against byte strings.

Review Request #10479 — Created March 31, 2019 and submitted — Latest diff uploaded

chipx86
Review Board
release-4.0.x
reviewboard

HttpResponse.content is a byte string, and we have a lot of tests
comparing these against Unicode strings. In Python 2, that's not a big
deal, but Python 3 heavily distinguishes between the two.

This change updates all comparisons to check only against byte strings.

Unit tests pass on Python 2.7 and 3.5-3.7 (with other in-progress
changes).

Commits

Files

Loading...