Compare HTTP responses against byte strings.

 






 

 


  Review Request #10479
  —
  Created March 31, 2019 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-4.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
HttpResponse.content is a byte string, and we have a lot of tests

comparing these against Unicode strings. In Python 2, that's not a big

deal, but Python 3 heavily distinguishes between the two.


This change updates all comparisons to check only against byte strings.

 








  


 
 

  
Unit tests pass on Python 2.7 and 3.5-3.7 (with other in-progress

changes).

 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Compare HTTP responses against byte strings.
     
`HttpResponse.content` is a byte string, and we have a lot of tests
comparing these against Unicode strings. In Python 2, that's not a big
deal, but Python 3 heavily distinguishes between the two.

This change updates all comparisons to check only against byte strings.

    

   
  		
  ef28ab2ea72ef62836d65cd7fa8528e253f3c441
  Christian Hammond
 


 
  
 
 
  
   
    

     Compare HTTP responses against byte strings.
     
`HttpResponse.content` is a byte string, and we have a lot of tests
comparing these against Unicode strings. In Python 2, that's not a big
deal, but Python 3 heavily distinguishes between the two.

This change updates all comparisons to check only against byte strings.

    

   
  		
  0e1193e96a64066cd5d694666fe5640e845dd4e9
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/reviews/tests/test_reviews_diff_fragment_view.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...