Make the jenkins plugin notification a little nicer.

Review Request #10384 — Created Jan. 15, 2019 and submitted

david
Jenkins plugin
master
85c1083...
jenkins-plugin

The jenkins plugin was initially written to update the status update on
the review request once the build completed (either successfully or
not). This change enhances the notification in several ways:

  • We now post a change to the status update when initially applying the
    patch. This will change the status from "starting build" (assigned by
    the integration) to "build running".
  • Add a link to the in-progress build.
  • Fix the post-build notification to properly use the error state
    instead of failure, when the build failed because of some non-code
    related issue.
  • Ran plugin unit tests.
  • Built and loaded the plugin into my Jenkins instance.
  • Posted a change to a review request. Saw that the status soon changed
    to "build running" with a correct link to the build. Saw that the
    build finished successfully.
Description From Last Updated

Blank line between these.

chipx86chipx86

How about using the format we use for querysets here? final ReviewBoardGlobalConfiguration globalConfig = ( GlobalConfiguration.all() .get(ReviewBoardGlobalConfiguration.class) ); Same below.

chipx86chipx86

Blank line between these.

chipx86chipx86

Blank line between these.

chipx86chipx86

No space after the cast.

chipx86chipx86

Can we make this wrap to 80 chars?

chipx86chipx86

Can we have a blank line between the cases, so it's easier to read?

chipx86chipx86
chipx86
  1. Basing the style-related comments on how we handle things in the rest of our codebases (and from what I recall being common back when I used to write Java code).

  2. Blank line between these.

  3. How about using the format we use for querysets here?

    final ReviewBoardGlobalConfiguration globalConfig = (
        GlobalConfiguration.all()
        .get(ReviewBoardGlobalConfiguration.class)
    );
    

    Same below.

  4. Blank line between these.

  5. Blank line between these.

  6. Can we make this wrap to 80 chars?

  7. src/main/java/org/reviewboard/rbjenkins/common/ReviewBoardUtils.java (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Can we have a blank line between the cases, so it's easier to read?

  8. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (85c1083)
Loading...