Make the jenkins plugin notification a little nicer.

Review Request #10384 — Created Jan. 15, 2019 and submitted — Latest diff uploaded

Information

Jenkins plugin
master
85c1083...

Reviewers

The jenkins plugin was initially written to update the status update on
the review request once the build completed (either successfully or
not). This change enhances the notification in several ways:

  • We now post a change to the status update when initially applying the
    patch. This will change the status from "starting build" (assigned by
    the integration) to "build running".
  • Add a link to the in-progress build.
  • Fix the post-build notification to properly use the error state
    instead of failure, when the build failed because of some non-code
    related issue.
  • Ran plugin unit tests.
  • Built and loaded the plugin into my Jenkins instance.
  • Posted a change to a review request. Saw that the status soon changed
    to "build running" with a correct link to the build. Saw that the
    build finished successfully.
    Loading...