Summary

Resize Image in Comment to Fit Page

Review Request #10353 — Created Dec. 10, 2018 and updated Dec. 13, 2018, 7:56 p.m.

Information

Owner

bolariinwa

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Commit

79dbb94...

Reviewers

Groups

reviewboard, students

People

Description

Images with large sizes had been previously oversized and flowed off the page
when placed in comments.

I made changes in the CSS to restrict the max-width of an image in a
comment to 100% bounding its size so it does not flow off the page.

Testing Done

Tested manually by checking if images in comments are resized to fit the
page and that on resizing the browser window, the new behaviour was observed.

Files

Issues

Description	From	Last Updated
I think the description of your fix could be a little more descriptive or clear by briefly explaining how you …	gojeffcho	Dec. 13, 2018, 7:57 p.m.

flake8 passed.

JSHint passed.

Testing Done:: ~
Tested by manually by checking if images in comment are resized to fit the
~
Tested manually by checking if images in comment are resized to fit the
page.

The issue has been resolved. Show all issues

I think the description of your fix could be a little more descriptive or clear by briefly explaining how you fixed it: for example, "max-width for images in reviewtext are constrained to 100%, ensuring that they fit within the page regardless of their original dimensions".

In Testing Done, I think "comment" should be "comments". Another trivial test to state might be about resizing the browser window.

Change Summary:: Resolved issues raised
Description:: ~
Images in comments had been previously oversized and flowed off the page.
~
Images with large sizes had been previously oversized and flowed off the page
+ when placed in comments.

~
I made changes in the CSS to restrict the image size to fit within the page.
~
I made changes in the CSS to restrict the max-width of an image in a
+ comment to 100% bounding its size so it does not flow off the page.
Testing Done:: ~
Tested manually by checking if images in comment are resized to fit the
~ page.
~
Tested manually by checking if images in comments are resized to fit the
~ page and that on resizing browser window, the new behaviour was observed.

Testing Done:: Tested manually by checking if images in comments are resized to fit the
~ page and that on resizing browser window, the new behaviour was observed.
~ page and that on resizing the browser window, the new behaviour was observed.

~		Tested by manually by checking if images in comment are resized to fit the
	~	Tested manually by checking if images in comment are resized to fit the
		page.

~		Images in comments had been previously oversized and flowed off the page.
	~	Images with large sizes had been previously oversized and flowed off the page
	+	when placed in comments.

~		I made changes in the CSS to restrict the image size to fit within the page.
	~	I made changes in the CSS to restrict the `max-width` of an image in a
	+	comment to `100%` bounding its size so it does not flow off the page.

		Tested manually by checking if images in comments are resized to fit the
~		page and that on resizing browser window, the new behaviour was observed.
	~	page and that on resizing the browser window, the new behaviour was observed.