Resize Image in Comment to Fit Page

Review Request #10353 — Created Dec. 10, 2018 and updated

bolariinwa
Review Board
release-4.0.x
79dbb94...
reviewboard, students

Images with large sizes had been previously oversized and flowed off the page
when placed in comments.

I made changes in the CSS to restrict the max-width of an image in a
comment to 100% bounding its size so it does not flow off the page.

Tested manually by checking if images in comments are resized to fit the
page and that on resizing the browser window, the new behaviour was observed.

Loading file attachments...

Description From Last Updated

I think the description of your fix could be a little more descriptive or clear by briefly explaining how you ...

gojeffchogojeffcho
bolariinwa
gojeffcho
  1. 
      
  2. I think the description of your fix could be a little more descriptive or clear by briefly explaining how you fixed it: for example, "max-width for images in reviewtext are constrained to 100%, ensuring that they fit within the page regardless of their original dimensions".

    In Testing Done, I think "comment" should be "comments". Another trivial test to state might be about resizing the browser window.

  3. 
      
bolariinwa
bolariinwa
Review request changed

Testing Done:

   

Tested manually by checking if images in comments are resized to fit the

~   page and that on resizing browser window, the new behaviour was observed.

  ~ page and that on resizing the browser window, the new behaviour was observed.

Loading...