Admin UI Shell Redesign
Review Request #10332 — Created Nov. 22, 2018 and updated
Update the Admin Shell UI to a more modern look in accordance with
the provided mockup. This redesign updates the color schemes and
makes UI elements more flat and readable. No major functionality
is impacted and changes are visual in nature.
Manual testing of updated pages and tabbed navbar.
Description | From | Last Updated |
---|---|---|
We don't use named HTML colours; instead, we use hex values. |
|
|
Hey Jeff! I'm liking the progress your making on this, I just have a tiny nitpick. Shouldn't this stick to … |
|
|
Is this the yellow at the top of the admin page? This should probably be a constant in defs.less. |
|
|
You probably already realize this but we will want some way of making the other tabs .active. |
|
|
I don't know how old this code is, but we should probably update from using view import paths to view … |
|
|
This property is out of alphabetical order. I know you didn't add it, but could you fix that? |
|
|
calc(@admin-sidebar-width - 1.5em) Fun fact: LESS will evaluate calc() statements so they are constants in the resulting CSS file. |
|
|
This is a repeated rule (.module has it already). |
|
|
.module.recent-actions should be specific enough to override .module without !important, unless something else is overriding it? |
|
|
This should be either border-top: none or border-top-width: 0px. |
|
|
Can you format as &:first-of-type > h2 ? It makes it more readable. |
|
|
While you're here, can you format this asfieldset > h2? Much more readable. |
|
|
calc(@admin-sidebar-width - 0.1em |
|
-
-
reviewboard/static/rb/css/pages/base.less (Diff revision 1) Hey Jeff! I'm liking the progress your making on this, I just have a tiny nitpick.
Shouldn't this stick to the length units you were using everywhere else?
In this case:
font-size: 120%;
-->font-size: 1.2em;
-
Redesign is coming along nicely!
-
reviewboard/static/rb/css/pages/base.less (Diff revision 1) We don't use named HTML colours; instead, we use hex values.
-
reviewboard/static/rb/css/pages/base.less (Diff revision 1) Is this the yellow at the top of the admin page? This should probably be a constant in
defs.less
. -
reviewboard/templates/admin/base_site.html (Diff revision 1) You probably already realize this but we will want some way of making the other tabs
.active
. -
reviewboard/templates/admin/base_site.html (Diff revision 1) I don't know how old this code is, but we should probably update from using view import paths to view names in the
{% url %}
tags here.If that isn't a thing we can do easily, don't worry about it.

Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+68 -58) |
Checks run (2 succeeded)

Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+86 -69) |
Checks run (2 succeeded)

Summary: |
|
|||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||
Testing Done: |
|
|||||||||||||||
Commit: |
|
|||||||||||||||
Diff: |
Revision 4 (+86 -69) |
Checks run (2 succeeded)

Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+64 -69) |
Checks run (2 succeeded)
-
-
reviewboard/static/rb/css/pages/admin-dashboard.less (Diff revision 5) This property is out of alphabetical order. I know you didn't add it, but could you fix that?
-
reviewboard/static/rb/css/pages/admin.less (Diff revision 5) calc(@admin-sidebar-width - 1.5em)
Fun fact: LESS will evaluate calc() statements so they are constants in the resulting CSS file.
-
reviewboard/static/rb/css/pages/admin.less (Diff revision 5) This is a repeated rule (
.module
has it already). -
reviewboard/static/rb/css/pages/admin.less (Diff revision 5) .module.recent-actions
should be specific enough to override.module
without!important
, unless something else is overriding it? -
reviewboard/static/rb/css/pages/admin.less (Diff revision 5) This should be either
border-top: none
orborder-top-width: 0px
. -
reviewboard/static/rb/css/pages/admin.less (Diff revision 5) Can you format as
&:first-of-type > h2
? It makes it more readable. -
reviewboard/static/rb/css/pages/admin.less (Diff revision 5) While you're here, can you format this as
fieldset > h2
? Much more readable. -

Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 6 (+66 -71) |