Admin UI Shell Redesign
Review Request #10332 — Created Nov. 22, 2018 and updated
Update the Admin Shell UI to a more modern look in accordance with
the provided mockup. This redesign updates the color schemes and
makes UI elements more flat and readable. No major functionality
is impacted and changes are visual in nature.
Manual testing of updated pages and tabbed navbar.
Description | From | Last Updated |
---|---|---|
We don't use named HTML colours; instead, we use hex values. |
brennie | |
Hey Jeff! I'm liking the progress your making on this, I just have a tiny nitpick. Shouldn't this stick to … |
Sudolicious | |
Is this the yellow at the top of the admin page? This should probably be a constant in defs.less. |
brennie | |
You probably already realize this but we will want some way of making the other tabs .active. |
brennie | |
I don't know how old this code is, but we should probably update from using view import paths to view … |
brennie | |
This property is out of alphabetical order. I know you didn't add it, but could you fix that? |
brennie | |
calc(@admin-sidebar-width - 1.5em) Fun fact: LESS will evaluate calc() statements so they are constants in the resulting CSS file. |
brennie | |
This is a repeated rule (.module has it already). |
brennie | |
.module.recent-actions should be specific enough to override .module without !important, unless something else is overriding it? |
brennie | |
This should be either border-top: none or border-top-width: 0px. |
brennie | |
Can you format as &:first-of-type > h2 ? It makes it more readable. |
brennie | |
While you're here, can you format this asfieldset > h2? Much more readable. |
brennie | |
calc(@admin-sidebar-width - 0.1em |
brennie |
- Commit:
-
046fe6e2fdd138097abb1e707dc794a334227ebdd22ba593f120ca381d0c2d0b34441ed10d186530
- Diff:
-
Revision 2 (+68 -58)
Checks run (2 succeeded)
- Commit:
-
d22ba593f120ca381d0c2d0b34441ed10d1865305a7fbe70c49f1ecd8b603caa97fbf4b9e0970c02
- Diff:
-
Revision 3 (+86 -69)
Checks run (2 succeeded)
- Summary:
-
[WIP] Admin Shell UI RedesignAdmin Shell UI Redesign
- Description:
-
~ Work in progress for the Admin Shell UI Redesign.
~ Update the Admin Shell UI to a more modern look in accordance with
+ the provided mockup. This redesign updates the color schemes and + makes UI elements more flat and readable. No major functionality + is impacted and changes are visual in nature. - Testing Done:
-
+ Manual testing of updated pages and tabbed navbar.
- Commit:
-
5a7fbe70c49f1ecd8b603caa97fbf4b9e0970c02cb912c3f4b8f9d9c38d3c34633c3d7556d87f030
- Diff:
-
Revision 4 (+86 -69)
Checks run (2 succeeded)
- Commit:
-
cb912c3f4b8f9d9c38d3c34633c3d7556d87f030e0a8100209ca4d6a92ec5fc636a394105a9463eb
- Diff:
-
Revision 5 (+64 -69)
Checks run (2 succeeded)
- Commit:
-
e0a8100209ca4d6a92ec5fc636a394105a9463eb81a83f6daa57afb5a5b1166f25a5cc5869b9182c
- Diff:
-
Revision 6 (+66 -71)