flake8
passed.
JSHint
passed.
Add ability for Review Bot tools to attach logs
Review Request #10318 — Created Nov. 8, 2018 and discarded
| Information | |
|---|---|
| ilaw | |
| ReviewBot | |
| master | |
| Reviewers | |
| reviewbot, students | |
Allows Review Bot tools to attach their console output to Status Updates.
Adds ability to attach output files to checkstyle, Cppcheck, CppLint, doc8,
flake8, JSHint, PMD, pycodestyle, pydocstyle, and pyflakes.Adds an option to the above-mentioned Review Bot tools to attach the output
files. The default is set to not attach files.
Tested ability to attach log files by configuring integrations with the
Review Bot tools, running each tool, and examining the attachments.
| Description | From | Last Updated |
|---|---|---|
|
Parentheses are not needed here. |
 brennie
|
|
|
You are running the tool twice here. |
brennie
|
|
|
E501 line too long (83 > 79 characters) |
 reviewbot
|
|
|
It might be helpful to add a comment explaining what the regex does so it's easier to read this code … |
 shoven
|
|
|
W292 no newline at end of file |
reviewbot
|
|
|
For this (and the other structures like it), since these ifs have no elses, would it be worth making it … |
 gojeffcho
|
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+13) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Summary: |
|
||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||||||||
Testing Done: |
|
||||||||||||||||||||||||
Commit: |
|
||||||||||||||||||||||||
Diff: |
Revision 3 (+251 -3) |
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
-
bot/reviewbot/tools/checkstyle.py (Diff revision 3) It might be helpful to add a comment explaining what the regex does so it's easier to read this code on first glance if one is not as familiar with regex.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+202 -3) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
bot/reviewbot/tools/cppcheck.py (Diff revision 4) For this (and the other structures like it), since these
ifs have noelses, would it be worth making itif settings['attach_log'] and output:?
