flake8
passed.
JSHint
passed.
Make some visual tweaks to commit display for DVCS.
Review Request #10308 — Created Nov. 6, 2018 and submitted
This change does some visual polish to the display of commits on the
review request:
- On the review request page, fixed the spacing between the "Commits"
label and the table (before there was none). - On the diff viewer page, hid the "Commits" field entirely, since its
content overlaps with that of the commit selector table. This was
especially confusing when the latest revision had a different set of
commits than the revision being viewed. - Fixed spacing of the different sections on the diff viewer page:
various diff "fields" had equal spacing above and below, and didn't
provide enough whitespace to really associate the label with the
item.
Viewed the reviews and diff viewer pages and saw that everything looked
much nicer.
| Description | From | Last Updated |
|---|---|---|
|
We should probably compare against diffviewer_url_names in reviewboard.urls, to cover all bases. |
 chipx86
|
|
|
Can we just import resolve directly from this, instead of grabbing the whole module? |
chipx86
|
|
|
Private methods should go at the bottom of the class. |
chipx86
|
|
|
Let's put this in a utility method, since we keep repeating with the same comment and logic. |
chipx86
|
-
-
reviewboard/reviews/builtin_fields.py (Diff revision 1) We should probably compare against
diffviewer_url_namesinreviewboard.urls, to cover all bases.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+38 -7) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/reviews/tests/test_builtin_fields.py (Diff revision 2) Can we just import
resolvedirectly from this, instead of grabbing the whole module? -
reviewboard/reviews/tests/test_builtin_fields.py (Diff revision 2) Let's put this in a utility method, since we keep repeating with the same comment and logic.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+40 -7) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/reviews/tests/test_builtin_fields.py (Diff revisions 2 - 3) Private methods should go at the bottom of the class.