Summary:

Allow publishing review requests without updating diff

Review Request #10283 — Created Oct. 26, 2018 and submitted Nov. 11, 2018, 10:22 a.m. — Latest diff uploaded Oct. 26, 2018, noon

Information
Owner:	brennie
Repository:	Review Board
Branch:	release-4.0.x
Bugs:
Depends On:
Commit:	a2855b1...
Reviewers
Groups:	reviewboard
People:

Description

The CommitListField was assuming the field changed even when a new
diff wasn't uploaded, resulting it it failing to record change entry
information and, ultimately, prevent publishing.

We now only mark the field as changed when a new diff is present.

Testing Done


Published a review request created with history when the diff was

  not updated.
Published a review request created with history when the diff was

  updated.