Allow publishing review requests without updating diff

Review Request #10283 — Created Oct. 26, 2018 and submitted

Information

Review Board
release-4.0.x
a2855b1...

Reviewers

The CommitListField was assuming the field changed even when a new
diff wasn't uploaded, resulting it it failing to record change entry
information and, ultimately, prevent publishing.

We now only mark the field as changed when a new diff is present.

  • Published a review request created with history when the diff was
    not updated.
  • Published a review request created with history when the diff was
    updated.
Description From Last Updated

Can you also test the positive case (field gets correctly updated when there's a new set of commits?)

daviddavid
david
  1. 
      
  2. Show all issues

    Can you also test the positive case (field gets correctly updated when there's a new set of commits?)

  3. 
      
brennie
david
  1. Ship It!
  2. 
      
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.0.x (27d3f5f)