This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-4.0.x (27d3f5f)

Summary

Allow publishing review requests without updating diff

Review Request #10283 — Created Oct. 26, 2018 and submitted 6 years, 5 months ago

Information

Owner

brennie*

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Commit

a2855b1...

Reviewers

Groups

reviewboard

People

Description*

The CommitListField was assuming the field changed even when a new
diff wasn't uploaded, resulting it it failing to record change entry
information and, ultimately, prevent publishing.

We now only mark the field as changed when a new diff is present.

Testing Done


Published a review request created with history when the diff was

  not updated.
Published a review request created with history when the diff was

  updated.

Issues

Description	From	Last Updated
Can you also test the positive case (field gets correctly updated when there's a new set of commits?)	david	6 years, 6 months ago
There are no open issues

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Can you also test the positive case (field gets correctly updated when there's a new set of commits?)

Testing Done:: ~
Published a review request created with history when the diff was not
~ updated.
~
Published a review request created with history when the diff was
not updated.
~
Published a review request created with history when the diff was
updated.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (27d3f5f)

~		Published a review request created with history when the diff was not
~		updated.
	~	Published a review request created with history when the diff was not updated.
	~	Published a review request created with history when the diff was updated.