Handle tuple returns from get_sort_field()
Review Request #10278 — Created Oct. 25, 2018 and updated
This fix enables handling of tuples as returns from a
Column
's
get_sort_field()
duringprecompute_objects()
. This is related to
the "Make all columns sortable on /users/ page" fix.
All tests pass for Djblets.
Description | From | Last Updated |
---|---|---|
No need to include "Djblets" in the title since it will land in Djblets :) |
|
|
Actually, this patch doesn't merge cleanly on the latest release-2.0.x. Could you pull and rebase? |
|
|
Old debug output? |
|
|
Looking at this one more time, I think we still need the truthy check here. Let's change this to be … |
|
|
My issue with this code it unfounded. |
|
|
Why is this not a triple-quoted comment |
|

Change Summary:
Took out a debugging line that snuck in.
Description: |
|
|||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
|||||||||||||||
Diff: |
Revision 2 (+5 -1) |
Checks run (2 succeeded)

Change Summary:
Rebased
Branch: |
|
||||
---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 3 (+5 -1) |
Checks run (2 succeeded)

Change Summary:
Rebased to 2.0.x instead of master.
Branch: |
|
||||
---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 4 (+4 -1) |
Checks run (2 succeeded)
-
-
djblets/datagrid/grids.py (Diff revision 4) Looking at this one more time, I think we still need the truthy check here. Let's change this to be
elif sort_field:

Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+9 -1) |