Summary

Handle tuple returns from get_sort_field()

Review Request #10278 — Created Oct. 25, 2018 and updated Nov. 20, 2018, 10:23 a.m.

Information

Owner

gojeffcho

Repository

Djblets

Branch

release-2.0.x

Bugs

Depends On

10277

Blocks

10277

Commit

d0adbe5...

Reviewers

Groups

djblets, students

People

Description

This fix enables handling of tuples as returns from a Column's
get_sort_field() during precompute_objects(). This is related to
the "Make all columns sortable on /users/ page" fix.

Testing Done

All tests pass for Djblets.

Issues

Description	From	Last Updated
No need to include "Djblets" in the title since it will land in Djblets :)	brennie	Nov. 6, 2018, 10:23 a.m.
Actually, this patch doesn't merge cleanly on the latest release-2.0.x. Could you pull and rebase?	david	Nov. 19, 2018, 12:22 p.m.
Old debug output?	zr5dt	Nov. 19, 2018, 2:04 p.m.
Looking at this one more time, I think we still need the truthy check here. Let's change this to be …	david	Nov. 20, 2018, 10:23 a.m.
My issue with this code it unfounded.	zr5dt	Nov. 19, 2018, 1:17 p.m.
Why is this not a triple-quoted comment	zr5dt	Nov. 19, 2018, 1:32 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Took out a debugging line that snuck in.

Description:

		This fix enables handling of tuples as returns from a `Column`'s
		`get_sort_field()` during `precompute_objects()`. This is related to
		the "Make all columns sortable on /users/ page" fix.
-
-		Unit tests still need to be written for this fix.

Commit:

-	89965b0231525adb418abb5d485c41d9ec18a6d2
+	3f9a5f4c4c678e877619b4b0a5b570a216907f86

Diff:

Revision 2 (+5 -1)

Show changes

djblets/datagrid/grids.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Out of WIP - minor update that enables #10277.

Summary:

-	[WIP] Djblets: Handle tuple returns from get_sort_field()
+	Djblets: Handle tuple returns from get_sort_field()

Show all issues

No need to include "Djblets" in the title since it will land in Djblets :)

Summary:

-	Djblets: Handle tuple returns from get_sort_field()
+	Handle tuple returns from get_sort_field()

```
Ship It!
```

Show all issues

Actually, this patch doesn't merge cleanly on the latest release-2.0.x. Could you pull and rebase?

Change Summary:

Rebased

Branch:

-	release-2.0.x
+	master

Commit:

-	3f9a5f4c4c678e877619b4b0a5b570a216907f86
+	7abd06dc4631f91b701a6e2869481db46af24c4c

Diff:

Revision 3 (+5 -1)

Show changes

djblets/datagrid/grids.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Rebased to 2.0.x instead of master.

Branch:

-	master
+	release-2.0.x

Commit:

-	7abd06dc4631f91b701a6e2869481db46af24c4c
+	06c14dff24b93f297c1823e47e45b30cccdd65e8

Diff:

Revision 4 (+4 -1)

Show changes

djblets/datagrid/grids.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

djblets/datagrid/grids.py (Diff revision 4)
```
This is a cool tool
```

Ship it!

```
Ship It!
```

djblets/datagrid/grids.py (Diff revision 4)
Show all issues
```
My issue with this code it unfounded.
```

djblets/datagrid/grids.py (Diff revision 4)

Show all issues

Why is this not a triple-quoted comment

djblets/datagrid/grids.py (Diff revision 1)
Show all issues
```
Old debug output?
```
1. gojeffcho Nov. 19, 2018, 2:04 p.m.
  It is, and is no longer present in the latest diff.

djblets/datagrid/grids.py (Diff revision 4)

Show all issues

Looking at this one more time, I think we still need the truthy check here. Let's change this to be elif sort_field:

Commit:

-	06c14dff24b93f297c1823e47e45b30cccdd65e8
+	d0adbe51160b68f299fea6dc2eeebaebc2760483

Diff:

Revision 5 (+9 -1)

Show changes

djblets/datagrid/grids.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.