Handle tuple returns from get_sort_field()
Review Request #10278 — Created Oct. 25, 2018 and updated
This fix enables handling of tuples as returns from a
Column
's
get_sort_field()
duringprecompute_objects()
. This is related to
the "Make all columns sortable on /users/ page" fix.
All tests pass for Djblets.
Description | From | Last Updated |
---|---|---|
No need to include "Djblets" in the title since it will land in Djblets :) |
|
|
Actually, this patch doesn't merge cleanly on the latest release-2.0.x. Could you pull and rebase? |
|
|
Old debug output? |
|
|
Looking at this one more time, I think we still need the truthy check here. Let's change this to be … |
|
|
My issue with this code it unfounded. |
|
|
Why is this not a triple-quoted comment |
|
![gojeffcho](https://media-reviews-reviewboard-org.s3.amazonaws.com/uploaded/avatars/g/go/gojeffcho__6d7a7f4c-0350-43c3-879f-3fd4fe3ca62b.png?AWSAccessKeyId=AKIAJXEP4CRSJE2AMHOQ&Signature=VX9lc%2F1lQ%2FnLJzjajjAcmdQzktI%3D&Expires=1722045921)
- Change Summary:
-
Took out a debugging line that snuck in.
- Description:
-
This fix enables handling of tuples as returns from a
Column
'sget_sort_field()
duringprecompute_objects()
. This is related tothe "Make all columns sortable on /users/ page" fix. - - Unit tests still need to be written for this fix.
- Commit:
-
89965b0231525adb418abb5d485c41d9ec18a6d23f9a5f4c4c678e877619b4b0a5b570a216907f86
- Diff:
-
Revision 2 (+5 -1)
Checks run (2 succeeded)
![gojeffcho](https://media-reviews-reviewboard-org.s3.amazonaws.com/uploaded/avatars/g/go/gojeffcho__6d7a7f4c-0350-43c3-879f-3fd4fe3ca62b.png?AWSAccessKeyId=AKIAJXEP4CRSJE2AMHOQ&Signature=VX9lc%2F1lQ%2FnLJzjajjAcmdQzktI%3D&Expires=1722045921)
- Change Summary:
-
Rebased
- Branch:
-
release-2.0.xmaster
- Commit:
-
3f9a5f4c4c678e877619b4b0a5b570a216907f867abd06dc4631f91b701a6e2869481db46af24c4c
- Diff:
-
Revision 3 (+5 -1)
Checks run (2 succeeded)
![gojeffcho](https://media-reviews-reviewboard-org.s3.amazonaws.com/uploaded/avatars/g/go/gojeffcho__6d7a7f4c-0350-43c3-879f-3fd4fe3ca62b.png?AWSAccessKeyId=AKIAJXEP4CRSJE2AMHOQ&Signature=VX9lc%2F1lQ%2FnLJzjajjAcmdQzktI%3D&Expires=1722045921)
- Change Summary:
-
Rebased to 2.0.x instead of master.
- Branch:
-
masterrelease-2.0.x
- Commit:
-
7abd06dc4631f91b701a6e2869481db46af24c4c06c14dff24b93f297c1823e47e45b30cccdd65e8
- Diff:
-
Revision 4 (+4 -1)
Checks run (2 succeeded)
![gojeffcho](https://media-reviews-reviewboard-org.s3.amazonaws.com/uploaded/avatars/g/go/gojeffcho__6d7a7f4c-0350-43c3-879f-3fd4fe3ca62b.png?AWSAccessKeyId=AKIAJXEP4CRSJE2AMHOQ&Signature=VX9lc%2F1lQ%2FnLJzjajjAcmdQzktI%3D&Expires=1722045921)
- Commit:
-
06c14dff24b93f297c1823e47e45b30cccdd65e8d0adbe51160b68f299fea6dc2eeebaebc2760483
- Diff:
-
Revision 5 (+9 -1)