[WIP]: Create an Extension that suggests reviewers

Review Request #10248 — Created Oct. 19, 2018 and updated

praiseA
Review Board
master
ff7ae01...
reviewboard, students

Summary of what this extension would do: When a user makes a review request,
if they enable this extension then they can get a suggestion about a reviewer
that would be the best to review the submitted code, given the files that
this user would like to review.

What I have done:
Created an extension folder called suggested_reviewers_extension and added an
extension.py that defines the basis of the extension. The file also creates
a JSExtension subclass that stores the right reviewer(s) in a variable that was
calculated from the models.py file so that the template.HTML can be dynamic
depending on who is meant to review the request.

I also created a template.HTML class that displays the suggested reviewer or on
default, displays that there is no one to suggest. Also, the template gets the DOM
element of the review-request-details and attaches the suggested_review div to that
element.

I'm working on the models.py file now to correctly return the right reviewer based
on the right weights and right variables.

  • Played around with Django models to extract reviewers
  • and the reviews that were made
  • Created an extension folder and implemented the extension.py
  • Added views.py and models.py files
  • 35
  • 0
  • 312
  • 22
  • 369
Description From Last Updated
Hey Praise! I looked at your code, and even after reading the Review Board documentation for extensions I still don't ... skaefer143 skaefer143
F401 'django.http.HttpResponse' imported but unused reviewbot reviewbot
E131 continuation line unaligned for hanging indent reviewbot reviewbot
E127 continuation line over-indented for visual indent reviewbot reviewbot
E999 SyntaxError: invalid syntax reviewbot reviewbot
E128 continuation line under-indented for visual indent reviewbot reviewbot
E999 SyntaxError: invalid syntax reviewbot reviewbot
E226 missing whitespace around arithmetic operator reviewbot reviewbot
E226 missing whitespace around arithmetic operator reviewbot reviewbot
E271 multiple spaces after keyword reviewbot reviewbot
W293 blank line contains whitespace reviewbot reviewbot
W293 blank line contains whitespace reviewbot reviewbot
E303 too many blank lines (3) reviewbot reviewbot
E128 continuation line under-indented for visual indent reviewbot reviewbot
W503 line break before binary operator reviewbot reviewbot
W292 no newline at end of file reviewbot reviewbot
F401 'django.http.HttpResponse' imported but unused reviewbot reviewbot
E231 missing whitespace after ':' reviewbot reviewbot
E131 continuation line unaligned for hanging indent reviewbot reviewbot
E127 continuation line over-indented for visual indent reviewbot reviewbot
E302 expected 2 blank lines, found 1 reviewbot reviewbot
W293 blank line contains whitespace reviewbot reviewbot
E128 continuation line under-indented for visual indent reviewbot reviewbot
W291 trailing whitespace reviewbot reviewbot
E999 SyntaxError: invalid syntax reviewbot reviewbot
E226 missing whitespace around arithmetic operator reviewbot reviewbot
E226 missing whitespace around arithmetic operator reviewbot reviewbot
E271 multiple spaces after keyword reviewbot reviewbot
W293 blank line contains whitespace reviewbot reviewbot
W293 blank line contains whitespace reviewbot reviewbot
E303 too many blank lines (3) reviewbot reviewbot
E128 continuation line under-indented for visual indent reviewbot reviewbot
W503 line break before binary operator reviewbot reviewbot
W292 no newline at end of file reviewbot reviewbot
F401 'django.http.HttpResponse' imported but unused reviewbot reviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

praiseA
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

praiseA
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

praiseA
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

praiseA
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

praiseA
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

praiseA
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

praiseA
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

praiseA
praiseA
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

praiseA
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

praiseA
Review request changed

Summary:

-[WIP]: Create a Suggestive reviewers Extension
+[WIP]: Create an Extension that suggests reviewers

Commit:

-b478a7e96d6671a30339967df067ed346cbd962d
+ad6cf8b15d96ba4b7cfec679342716996b883148

Diff:

Revision 11 (+475)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

praiseA
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8