Make pycodestyle and pyflakes an optional dependency under "all"

Review Request #10218 — Created Oct. 11, 2018 and submitted

alextechcc
ReviewBot
master
10151
d98582b...
reviewbot, students

The documentation incorrectly stated that these tools were
"automatically installed", as they were not dependencies in setup.py.
These dependencies were added to the optional 'all' target, and the
documentation updated accordingly.

Since this is just a change for Python dependencies I've done:
- pip install -e ./bot
- pip install -e ./bot[all]

To test if it installs and doesn't install pycodestyle and pyflakes
under the default package and the all target, and according to the
logs this is the case.

  • 0
  • 0
  • 4
  • 0
  • 4
Description From Last Updated
brennie
  1. 
      
  2. Your testing done indicates that you ran:

    pip install -e ./bot reviewbot-worker
    pip install -e ./bot reviewbot-worker[all]
    

    Both of these commands will do the following:

    1. Run setup.py in the ./bot folder and
    2. Install reviewbot-worker from PyPI.

    Your second command will not result in the all dependencies being installed.

    Instead, what you should be running is:

    pip install -e ./bot
    pip install -e ./bot[all]
    
  3. 
      
alextechcc
brennie
  1. 
      
  2. Remove Easyfix from the summary

  3. In your testing done it should say "Python dependencies" instead of "pip dependencies"

  4. 
      
alextechcc
brennie
  1. 
      
  2. Capital P Python.

  3. 
      
alextechcc
david
  1. Ship It!
  2. 
      
alextechcc
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (2b4ec73)
Loading...