EasyFix: Make flake8 an optional dependency under "all"

Review Request #10151 — Created Sept. 21, 2018 and submitted

alextechcc
ReviewBot
master
10218
4815c03...
reviewbot, students

The new "all" optional dependency target is intended to replicate the
old behavior of installing all python dependencies.

Documentation has been updated to reflect this.

Since this is just a change for pip dependencies I've done:
- pip install -e ./bot reviewbot-worker
- pip install -e ./bot reviewbot-worker[all]
To test if it installs and doesn't install flake8 under the default
package and the all target, and according to the logs this is the case.

  • 0
  • 0
  • 4
  • 0
  • 4
Description From Last Updated
alextechcc
david
  1. 
      
  2. Please wrap your testing done to 72 columns (it goes into the commit message)

  3. bot/setup.py (Diff revision 1)
     
     

    Can we call this "all" instead of "ALL"?

    Also, a couple formatting nits:

    • One space between the : and the [
    • Let's split the list into one line per item, since we know we'll be adding more to it in the future.
  4. 
      
david
  1. 
      
  2. docs/reviewbot/tools/flake8.rst (Diff revision 2)
     
     

    Can we say "pip install flake8" so people can just copy and paste?

  3. 
      
alextechcc
alextechcc
david
  1. 
      
  2. Can you fix the summary to say "all" instead of "ALL"?

  3. 
      
alextechcc
alextechcc
mike_conley
  1. Looks good to me - thanks!

  2. 
      
david
  1. Ship It!
  2. 
      
alextechcc
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (1e8a677)
Loading...