flake8
passed.
JSHint
passed.
Make pycodestyle and pyflakes an optional dependency under "all"
Review Request #10218 — Created Oct. 11, 2018 and submitted
The documentation incorrectly stated that these tools were
"automatically installed", as they were not dependencies insetup.py.
These dependencies were added to the optional 'all' target, and the
documentation updated accordingly.
Since this is just a change for Python dependencies I've done:
-pip install -e ./bot
-pip install -e ./bot[all]To test if it installs and doesn't install pycodestyle and pyflakes
under the default package and the all target, and according to the
logs this is the case.
| Description | From | Last Updated |
|---|---|---|
|
Your testing done indicates that you ran: pip install -e ./bot reviewbot-worker pip install -e ./bot reviewbot-worker[all] Both of these … |
 brennie
|
|
|
Remove Easyfix from the summary |
brennie
|
|
|
In your testing done it should say "Python dependencies" instead of "pip dependencies" |
brennie
|
|
|
Capital P Python. |
brennie
|
-
-
Your testing done indicates that you ran:
pip install -e ./bot reviewbot-worker pip install -e ./bot reviewbot-worker[all]Both of these commands will do the following:
- Run
setup.pyin the./botfolder and - Install reviewbot-worker from PyPI.
Your second command will not result in the
alldependencies being installed.Instead, what you should be running is:
pip install -e ./bot pip install -e ./bot[all] - Run
- Testing Done:
-
Since this is just a change for pip dependencies I've done:
~ - pip install -e ./bot reviewbot-worker~ - pip install -e ./bot reviewbot-worker[all]~ - pip install -e ./bot~ - pip install -e ./bot[all]To test if it installs and doesn't install pycodestyle and pyflakes
under the default package and the all target, and according to the logs this is the case.
- Summary:
-
EasyFix: Make pycodestyle and pyflakes an optional dependency under "all"Make pycodestyle and pyflakes an optional dependency under "all"
- Testing Done:
-
~ Since this is just a change for pip dependencies I've done:
~ Since this is just a change for python dependencies I've done:
- pip install -e ./bot- pip install -e ./bot[all]To test if it installs and doesn't install pycodestyle and pyflakes
under the default package and the all target, and according to the logs this is the case.
- Testing Done:
-
~ Since this is just a change for python dependencies I've done:
~ Since this is just a change for Python dependencies I've done:
- pip install -e ./bot- pip install -e ./bot[all]To test if it installs and doesn't install pycodestyle and pyflakes
under the default package and the all target, and according to the logs this is the case.
