[WIP] Replace old selectors with smarter objects selector widget in the administration UI

Review Request #10215 — Created Oct. 10, 2018 and updated

skaefer143
Review Board
master
10214
c383d3c...
reviewboard, students

[Work in Progress]

Moved RelatedObjectWidget into Djblets. The widget is imported from Djblets
now, and extended by RelatedUserWidget.

Created RelatedRepositoryWidget, along with related HTML and JS files, which
extends the RelatedObjectsWidget. Currently displaying on
/admin/db/reviews/defaultreviewer/add/, but doesn't function.

See /r/10214.

Ran ./tests/runtests.py and no errors were thrown.

Navigated to /admin/db/reviews/defaultreviewer/add/ and the Smart
Select User Widget works as normal. The RelatedRepositoryWidget
doesn't currently function.

  • 0
  • 0
  • 4
  • 0
  • 4
Description From Last Updated
brennie
  1. 
      
  2. Instead of "See patch #10214" you can do:

    See /r/10214/.
    

    and it will be linked correctly. (e.g. /r/10214/)

  3. You also need to migrate the template.

  4. 
      
skaefer143
skaefer143
skaefer143
skaefer143
brennie
  1. 
      
  2. This doesn't need to live on the prototype. It can live as a global (const searchPlaceholderText = ...) since you're wrapping everything in an IIFE.

  3. 
      
skaefer143
Review request changed

Change Summary:

The RelatedRepositoryWidget functions and renders responses now. It is also extending Djblets.RelatedObjectSelectorView now, instead of using RB..

Commit:

-d5e82c3e4862c66cbb0f0510996466c03b931848
+64a92a43ad1e5ee9b9799e0ddbd1f3c3fd3b2036

Diff:

Revision 6 (+235 -370)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

skaefer143
Review request changed
Loading...