flake8
passed.
JSHint
passed.
EasyFix: Make flake8 an optional dependency under "all"
Review Request #10151 — Created Sept. 21, 2018 and submitted
The new "all" optional dependency target is intended to replicate the
old behavior of installing all python dependencies.Documentation has been updated to reflect this.
Since this is just a change for pip dependencies I've done:
-pip install -e ./bot reviewbot-worker
-pip install -e ./bot reviewbot-worker[all]
To test if it installs and doesn't install flake8 under the default
package and the all target, and according to the logs this is the case.
| Description | From | Last Updated |
|---|---|---|
|
Please wrap your testing done to 72 columns (it goes into the commit message) |
 david
|
|
|
Can you fix the summary to say "all" instead of "ALL"? |
david
|
|
|
Can we call this "all" instead of "ALL"? Also, a couple formatting nits: One space between the : and the … |
david
|
|
|
Can we say "pip install flake8" so people can just copy and paste? |
david
|
- Change Summary:
-
Updated documentation to reflect flake8 not being handled by installing reviewbot-worker
- Description:
-
The new "ALL" optional dependency target is intended to replicate the
old behavior of installing all python dependencies. + + Documentation has been updated to reflect this.
- Commit:
-
0c731112a7613fb94fb9983242de5a22bd1d850ce3d973014a7a78fd98b029196e8a6204989a74e4
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
Fixed style and added full pip command to install flake8
- Testing Done:
-
Since this is just a change for pip dependencies I've done:
- pip install -e ./bot reviewbot-worker- pip install -e ./bot reviewbot-worker[ALL]~ To test if it installs and doesn't install flake8 under the default package and the ALL target, and according to the logs this is the case. ~ To test if it installs and doesn't install flake8 under the default + package and the ALL target, and according to the logs this is the case. - Commit:
-
e3d973014a7a78fd98b029196e8a6204989a74e44815c03fce6ce3631a95b36ffbdb496e34ab4c42
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Description:
-
~ The new "ALL" optional dependency target is intended to replicate the
~ The new "all" optional dependency target is intended to replicate the
old behavior of installing all python dependencies. Documentation has been updated to reflect this.
- Testing Done:
-
Since this is just a change for pip dependencies I've done:
- pip install -e ./bot reviewbot-worker~ - pip install -e ./bot reviewbot-worker[ALL]~ - pip install -e ./bot reviewbot-worker[all]To test if it installs and doesn't install flake8 under the default package and the ALL target, and according to the logs this is the case.
- Testing Done:
-
Since this is just a change for pip dependencies I've done:
- pip install -e ./bot reviewbot-worker- pip install -e ./bot reviewbot-worker[all]To test if it installs and doesn't install flake8 under the default ~ package and the ALL target, and according to the logs this is the case. ~ package and the all target, and according to the logs this is the case.
