This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-4.0.x (d0a58dd)

Summary

Add controls to select base and tip commits in the RB.DiffCommitListView

Review Request #10132 — Created Aug. 30, 2018 and submitted 6 years, 6 months ago

Information

Owner

brennie*

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

~~10128~~

Blocks

10136

Commit

3391784...

Reviewers

Groups

reviewboard

People

Description*

The RB.DiffCommitListView can now optionally display controls for
selecting between base and tip commits to control what will be displayed
in the diffviewer. The actual logic for changing the diffs is not yet
implemented -- just the control itself.

Testing Done

Ran JS tests.

Files

Control preview

Issues

Description	From	Last Updated
Screenshot?	david	6 years, 7 months ago
Col: 36 Missing semicolon.	reviewbot	6 years, 8 months ago
Col: 55 Missing semicolon.	reviewbot	6 years, 8 months ago
Col: 36 Missing semicolon.	reviewbot	6 years, 8 months ago
Col: 55 Missing semicolon.	reviewbot	6 years, 8 months ago
Col: 36 Missing semicolon.	reviewbot	6 years, 8 months ago
Col: 55 Missing semicolon.	reviewbot	6 years, 8 months ago
Col: 36 Missing semicolon.	reviewbot	6 years, 8 months ago
Alphabetical order.	chipx86	6 years, 8 months ago
If there is no parent in the collection.	chipx86	6 years, 8 months ago
Indentation is incorrect for the comment.	chipx86	6 years, 8 months ago
Alphabetical order.	chipx86	6 years, 8 months ago
Alphabetical order.	chipx86	6 years, 8 months ago
Alphabetical order.	chipx86	6 years, 8 months ago
"Option Args"	chipx86	6 years, 8 months ago
Indentation is wrong. This would fit on one line though.	chipx86	6 years, 8 months ago
Parents around the ternary. The ? and : should also align with tipCommitID.	chipx86	6 years, 8 months ago
You can start the first parameter on the listenTo line.	chipx86	6 years, 8 months ago
Missing docs.	chipx86	6 years, 8 months ago
This looks like leftover debugging? Maybe just put a TODO here, or leave out the function until it's implemented.	chipx86	6 years, 8 months ago
There are no open issues

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 36
 Missing semicolon.
```

Change Summary:

jshint

Commit:

d94e73216a2731f8145db559c678ed794548eed2

dd6049fdc52410a490dbaec773c9fc57ec42bee2

Diff:

Revision 2 (+466 -46)

Show changes

	reviewboard/diffviewer/models/diffcommit.py
	reviewboard/static/rb/css/pages/review-request.less
	reviewboard/static/rb/js/diffviewer/models/diffCommit.es6.js
	reviewboard/static/rb/js/diffviewer/models/diffCommitListModel.es6.js
	reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js
	reviewboard/static/rb/js/diffviewer/views/tests/diffCommitListViewTests.es6.js
	reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Rebase.

Commit:

dd6049fdc52410a490dbaec773c9fc57ec42bee2

40d70a155fabe498aa9da5727b3e0d500b6584a2

Diff:

Revision 3 (+465 -42)

Show changes

	reviewboard/diffviewer/models/diffcommit.py
	reviewboard/static/rb/css/pages/review-request.less
	reviewboard/static/rb/js/diffviewer/models/diffCommit.es6.js
	reviewboard/static/rb/js/diffviewer/models/diffCommitListModel.es6.js
	reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js
	reviewboard/static/rb/js/diffviewer/views/tests/diffCommitListViewTests.es6.js
	reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Use PKs over commit IDs

Commit:

40d70a155fabe498aa9da5727b3e0d500b6584a2

b8dbaac0cdab0f09f31d5cd4664940a8852cdfce

Diff:

Revision 4 (+501 -42)

Show changes

	reviewboard/diffviewer/models/diffcommit.py
	reviewboard/static/rb/css/pages/review-request.less
	reviewboard/static/rb/js/diffviewer/collections/diffCommitCollection.es6.js
	reviewboard/static/rb/js/diffviewer/models/diffCommit.es6.js
	reviewboard/static/rb/js/diffviewer/models/diffCommitListModel.es6.js
	reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js
	reviewboard/static/rb/js/diffviewer/views/tests/diffCommitListViewTests.es6.js
	reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 55
 Missing semicolon.
```
reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 36
 Missing semicolon.
```

Change Summary:

CommitId -> CommitID

Commit:

b8dbaac0cdab0f09f31d5cd4664940a8852cdfce

a8d48b089479dad6e428c256a5407aae78668636

Diff:

Revision 5 (+501 -42)

Show changes

	reviewboard/diffviewer/models/diffcommit.py
	reviewboard/static/rb/css/pages/review-request.less
	reviewboard/static/rb/js/diffviewer/collections/diffCommitCollection.es6.js
	reviewboard/static/rb/js/diffviewer/models/diffCommit.es6.js
	reviewboard/static/rb/js/diffviewer/models/diffCommitListModel.es6.js
	reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js
	reviewboard/static/rb/js/diffviewer/views/tests/diffCommitListViewTests.es6.js
	reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 55
 Missing semicolon.
```
reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 36
 Missing semicolon.
```

Change Summary:

CommitId -> CommitID

Commit:

a8d48b089479dad6e428c256a5407aae78668636

5d7974aaa61deb8c8a3e0f8b069b1f6c10c4df07

Diff:

Revision 6 (+502 -42)

Show changes

	reviewboard/diffviewer/models/diffcommit.py
	reviewboard/static/rb/css/pages/review-request.less
	reviewboard/static/rb/js/diffviewer/collections/diffCommitCollection.es6.js
	reviewboard/static/rb/js/diffviewer/models/diffCommit.es6.js
	reviewboard/static/rb/js/diffviewer/models/diffCommitListModel.es6.js
	reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js
	reviewboard/static/rb/js/diffviewer/views/tests/diffCommitListViewTests.es6.js
	reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 55
 Missing semicolon.
```
reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 36
 Missing semicolon.
```

Change Summary:

jshint

Commit:

5d7974aaa61deb8c8a3e0f8b069b1f6c10c4df07

7dc3256855ee1bad9194f4f2a097d42dc239ecf0

Diff:

Revision 7 (+502 -42)

Show changes

	reviewboard/diffviewer/models/diffcommit.py
	reviewboard/static/rb/css/pages/review-request.less
	reviewboard/static/rb/js/diffviewer/collections/diffCommitCollection.es6.js
	reviewboard/static/rb/js/diffviewer/models/diffCommit.es6.js
	reviewboard/static/rb/js/diffviewer/models/diffCommitListModel.es6.js
	reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js
	reviewboard/static/rb/js/diffviewer/views/tests/diffCommitListViewTests.es6.js
	reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/diffviewer/models/diffcommit.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Alphabetical order.
```
reviewboard/static/rb/js/diffviewer/collections/diffCommitCollection.es6.js (Diff revision 7)
The issue has been resolved. Show all issues
```
If there is no parent in the collection.
```

reviewboard/static/rb/js/diffviewer/collections/diffCommitCollection.es6.js (Diff revision 7)

The issue has been resolved. Show all issues

Indentation is incorrect for the comment.

reviewboard/static/rb/js/diffviewer/models/diffCommitListModel.es6.js (Diff revision 7)
The issue has been resolved. Show all issues
```
Alphabetical order.
```

reviewboard/static/rb/js/diffviewer/models/diffCommitListModel.es6.js (Diff revision 7)

The issue has been resolved. Show all issues

Alphabetical order.

reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 7)

The issue has been resolved. Show all issues

Alphabetical order.

reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 7)
The issue has been resolved. Show all issues
```
"Option Args"
```
reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 7)
The issue has been resolved. Show all issues
```
Indentation is wrong.
This would fit on one line though.
```

reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js (Diff revision 7)

The issue has been resolved. Show all issues

Parents around the ternary.

The ? and : should also align with tipCommitID.

reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 7)

The issue has been resolved. Show all issues

You can start the first parameter on the listenTo line.

reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 7)
The issue has been resolved. Show all issues
```
Missing docs.
```

reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 7)

The issue has been resolved. Show all issues

This looks like leftover debugging?
Maybe just put a TODO here, or leave out the function until it's implemented.

Change Summary:

Addressed feedback.

Commit:

7dc3256855ee1bad9194f4f2a097d42dc239ecf0

bd800863428aee90eac9692467f176d6a02c1045

Diff:

Revision 8 (+488 -40)

Show changes

	reviewboard/diffviewer/models/diffcommit.py
	reviewboard/static/rb/css/pages/review-request.less
	reviewboard/static/rb/js/diffviewer/collections/diffCommitCollection.es6.js
	reviewboard/static/rb/js/diffviewer/models/diffCommit.es6.js
	reviewboard/static/rb/js/diffviewer/models/diffCommitListModel.es6.js
	reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js
	reviewboard/static/rb/js/diffviewer/views/tests/diffCommitListViewTests.es6.js
	reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues
```
Screenshot?
```

Added Files:: Review

Download

Control preview

Change Summary:

Addressed feedback.

Commit:

bd800863428aee90eac9692467f176d6a02c1045

3391784d04c69d3d283713e2d61f0492e31fb2e8

Diff:

Revision 9 (+494 -40)

Show changes

	reviewboard/diffviewer/models/diffcommit.py
	reviewboard/static/rb/css/pages/review-request.less
	reviewboard/static/rb/js/diffviewer/collections/diffCommitCollection.es6.js
	reviewboard/static/rb/js/diffviewer/models/diffCommitListModel.es6.js
	reviewboard/static/rb/js/diffviewer/models/diffCommitModel.es6.js
	reviewboard/static/rb/js/diffviewer/models/tests/diffCommitModelTests.es6.js
	reviewboard/static/rb/js/diffviewer/views/diffCommitListView.es6.js
	reviewboard/static/rb/js/diffviewer/views/tests/diffCommitListViewTests.es6.js
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (d0a58dd)