flake8
passed.
JSHint
passed.
Add hook instructions for RB Gateway
Review Request #10054 — Created July 2, 2018 and submitted
Now the RB Gateway supports hooks, we can provide instructions on how to
install them so that pushed commits corresponding to review requests can
be automatically closed.
Viewed the hook installation instructions.
| Description | From | Last Updated |
|---|---|---|
|
Missing arguments and returns. |
 chipx86
|
|
|
Missing space before this. |
chipx86
|
|
|
Missing </p>. |
chipx86
|
|
|
Is this the name on RB Gateway, or is "reviewboard-close" valid? |
chipx86
|
|
|
Missing </p>. |
chipx86
|
|
|
Let's put a $ before each command, to indicate a shell. |
chipx86
|
|
|
No space before systemd. |
chipx86
|
-
-
-
reviewboard/templates/hostingsvcs/rb-gateway/repo_hook_instructions.html (Diff revision 1) Missing space before this.
-
reviewboard/templates/hostingsvcs/rb-gateway/repo_hook_instructions.html (Diff revision 1) Missing
</p>. -
reviewboard/templates/hostingsvcs/rb-gateway/repo_hook_instructions.html (Diff revision 1) Is this the name on RB Gateway, or is "reviewboard-close" valid?
-
reviewboard/templates/hostingsvcs/rb-gateway/repo_hook_instructions.html (Diff revision 1) Missing
</p>. -
reviewboard/templates/hostingsvcs/rb-gateway/repo_hook_instructions.html (Diff revision 1) Let's put a
$before each command, to indicate a shell. -
reviewboard/templates/hostingsvcs/rb-gateway/repo_hook_instructions.html (Diff revision 1) No space before
systemd.
Change Summary:
Addressed the majority of feedback.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+95 -1) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Change Summary:
Addressed remaining feedback.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+95 -1) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.