flake8
failed.
JSHint
passed.
flake8
-
reviewboard/hostingsvcs/rbgateway.py (Diff revision 1) Show all issues
Close review requests from RB Gateway webhook payloads
Review Request #10038 — Created June 25, 2018 and submitted
| Information | |
|---|---|
| brennie | |
| Review Board | |
| release-3.0.x | |
| 10054 | |
| 0d9db6b... | |
| Reviewers | |
| reviewboard | |
The RB Gateway hosting service can now receive a payload from a RB
Gateway webhook (triggered by, e.g., agit push), which result in the
appropriate review requests being marked as submitted.Co-authored-by: Florie Cai floriecai@hotmail.com
- Ran unit tests.
- Closed a review request as submitted with a webhook.
| Description | From | Last Updated |
|---|---|---|
|
This needs unit tests for the hook that covers all the response scenarios. |
 chipx86
|
|
|
F401 'reviewboard.hostingsvcs.hook_utils.get_git_branch_name' imported but unused |
 reviewbot
|
|
|
These should all be ", optional", no? |
 david
|
|
|
Can we build the string to put in there up-front, and then inject into the map? That'll simplify the code … |
chipx86
|
|
|
"unpublished Git repository"? I think this should be "Unpublished review request on a Git repository?", right? If so, this needs … |
chipx86
|
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+133 -2) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Change Summary:
Addressed David's feedback.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+133 -2) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Change Summary:
Addressed Christian's feedback.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+536 -4) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/hostingsvcs/rbgateway.py (Diff revision 4) Can we build the string to put in there up-front, and then inject into the map? That'll simplify the code here a fair bit.
-
reviewboard/hostingsvcs/tests/test_rbgateway.py (Diff revision 4) "unpublished Git repository"?
I think this should be "Unpublished review request on a Git repository?", right? If so, this needs to be updated below as well.
Change Summary:
Addressed Christian's issues
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 5 (+536 -4) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.