- Download Diff

Summary:

Close review requests from RB Gateway webhook payloads

Review Request #10038 — Created June 25, 2018 and submitted July 3, 2018, 5:24 p.m.

Information
Owner:	brennie
Repository:	Review Board
Branch:	release-3.0.x
Bugs:
Depends On:
Blocks:	10054
Commit:	0d9db6b...
Reviewers
Groups:	reviewboard
People:

Description

The RB Gateway hosting service can now receive a payload from a RB
Gateway webhook (triggered by, e.g., a git push), which result in the
appropriate review requests being marked as submitted.

Co-authored-by: Florie Cai floriecai@hotmail.com

Testing Done


Ran unit tests.
Closed a review request as submitted with a webhook.

Issues

0
0
5
0
All Issues: 5

Description	From	Last Updated
This needs unit tests for the hook that covers all the response scenarios.	chipx86	July 2, 2018, 9:05 p.m.
F401 'reviewboard.hostingsvcs.hook_utils.get_git_branch_name' imported but unused	reviewbot	June 25, 2018, 2:17 p.m.
These should all be ", optional", no?	david	July 2, 2018, 3:56 p.m.
Can we build the string to put in there up-front, and then inject into the map? That'll simplify the code ...	chipx86	July 3, 2018, 4:59 p.m.
"unpublished Git repository"? I think this should be "Unpublished review request on a Git repository?", right? If so, this needs ...	chipx86	July 3, 2018, 5 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/rbgateway.py (Diff revision 1)

Show all issues

F401 'reviewboard.hostingsvcs.hook_utils.get_git_branch_name' imported but unused

Commit:

-	0bbb44fb49ed5d02d24b4294b1dfaced8592f8de
+	5f49653d857d7a3c0696821b10d7f654283c6590

Diff:

Revision 2 (+133 -2)

Show changes

	reviewboard/hostingsvcs/rbgateway.py
	reviewboard/hostingsvcs/tests/test_rbgateway.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/hostingsvcs/rbgateway.py (Diff revision 2)

Show all issues

These should all be ", optional", no?

Change Summary:

Addressed David's feedback.

Commit:

-	5f49653d857d7a3c0696821b10d7f654283c6590
+	02fc28b6286a7ef327a9af92cd18df221e8eb18c

Diff:

Revision 3 (+133 -2)

Show changes

	reviewboard/hostingsvcs/rbgateway.py
	reviewboard/hostingsvcs/tests/test_rbgateway.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Show all issues

This needs unit tests for the hook that covers all the response scenarios.

Change Summary:

Addressed Christian's feedback.

Commit:

-	02fc28b6286a7ef327a9af92cd18df221e8eb18c
+	49e0241c205af22f7d760b790b2aff2efaa9702a

Diff:

Revision 4 (+536 -4)

Show changes

	reviewboard/hostingsvcs/rbgateway.py
	reviewboard/hostingsvcs/tests/test_rbgateway.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/hostingsvcs/rbgateway.py (Diff revision 4)

Show all issues

Can we build the string to put in there up-front, and then inject into the map? That'll simplify the code here a fair bit.

reviewboard/hostingsvcs/tests/test_rbgateway.py (Diff revision 4)

Show all issues

"unpublished Git repository"?

I think this should be "Unpublished review request on a Git repository?", right? If so, this needs to be updated below as well.

Change Summary:

Addressed Christian's issues

Commit:

-	49e0241c205af22f7d760b790b2aff2efaa9702a
+	0d9db6bade562a8a807ab2b6b8d21fa7608ba889

Diff:

Revision 5 (+536 -4)

Show changes

	reviewboard/hostingsvcs/rbgateway.py
	reviewboard/hostingsvcs/tests/test_rbgateway.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (a2eaf2b)

You have a pending review.

Review Board 4.0 alpha 0 (dev)

Close review requests from RB Gateway webhook payloads

flake8

Commit:

Diff:

Checks run (2 succeeded)

Change Summary:

Commit:

Diff:

Checks run (2 succeeded)

Change Summary:

Commit:

Diff:

Checks run (2 succeeded)

Change Summary:

Commit:

Diff:

Checks run (2 succeeded)

Status: Closed (submitted)

Change Summary: