Close review requests from RB Gateway webhook payloads

Review Request #10038 — Created June 25, 2018 and submitted

Information

Review Board
release-3.0.x
0d9db6b...

Reviewers

The RB Gateway hosting service can now receive a payload from a RB
Gateway webhook (triggered by, e.g., a git push), which result in the
appropriate review requests being marked as submitted.

Co-authored-by: Florie Cai floriecai@hotmail.com

  • Ran unit tests.
  • Closed a review request as submitted with a webhook.
Description From Last Updated

This needs unit tests for the hook that covers all the response scenarios.

chipx86chipx86

F401 'reviewboard.hostingsvcs.hook_utils.get_git_branch_name' imported but unused

reviewbotreviewbot

These should all be ", optional", no?

daviddavid

Can we build the string to put in there up-front, and then inject into the map? That'll simplify the code …

chipx86chipx86

"unpublished Git repository"? I think this should be "Unpublished review request on a Git repository?", right? If so, this needs …

chipx86chipx86
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

brennie
david
  1. 
      
  2. reviewboard/hostingsvcs/rbgateway.py (Diff revision 2)
     
     
     
     
     
     
     
     
     
    Show all issues

    These should all be ", optional", no?

  3. 
      
brennie
chipx86
  1. 
      
  2. Show all issues

    This needs unit tests for the hook that covers all the response scenarios.

  3. 
      
brennie
chipx86
  1. 
      
  2. reviewboard/hostingsvcs/rbgateway.py (Diff revision 4)
     
     
     
     
     
     
     
    Show all issues

    Can we build the string to put in there up-front, and then inject into the map? That'll simplify the code here a fair bit.

  3. Show all issues

    "unpublished Git repository"?

    I think this should be "Unpublished review request on a Git repository?", right? If so, this needs to be updated below as well.

  4. 
      
brennie
chipx86
  1. Ship It!
  2. 
      
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.0.x (a2eaf2b)