Summary

Add hook instructions for RB Gateway

Review Request #10054 — Created July 2, 2018 and submitted July 3, 2018, 5:24 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

~~10038~~

Commit

1534c8d...

Reviewers

Groups

reviewboard

People

Description

Now the RB Gateway supports hooks, we can provide instructions on how to
install them so that pushed commits corresponding to review requests can
be automatically closed.

Testing Done

Viewed the hook installation instructions.

Files

Issues

Description	From	Last Updated
Missing arguments and returns.	chipx86	July 2, 2018, 9:07 p.m.
Missing space before this.	chipx86	July 2, 2018, 9:07 p.m.
Missing </p>.	chipx86	July 2, 2018, 9:07 p.m.
Is this the name on RB Gateway, or is "reviewboard-close" valid?	chipx86	July 3, 2018, 2:09 p.m.
Missing </p>.	chipx86	July 2, 2018, 9:08 p.m.
Let's put a $ before each command, to indicate a shell.	chipx86	July 2, 2018, 9:08 p.m.
No space before systemd.	chipx86	July 2, 2018, 9:08 p.m.

flake8 passed.

JSHint passed.

reviewboard/hostingsvcs/rbgateway.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing arguments and returns.
```
reviewboard/templates/hostingsvcs/rb-gateway/repo_hook_instructions.html (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing space before this.
```

reviewboard/templates/hostingsvcs/rb-gateway/repo_hook_instructions.html (Diff revision 1)

The issue has been resolved. Show all issues

Missing </p>.

reviewboard/templates/hostingsvcs/rb-gateway/repo_hook_instructions.html (Diff revision 1)
The issue has been resolved. Show all issues
```
Is this the name on RB Gateway, or is "reviewboard-close" valid?
```
1. brennie July 2, 2018, 7:22 p.m.
  The name is arbitrary.
2. chipx86 July 2, 2018, 9:55 p.m.
  Cool, let's use "reviewboard-close" then. We never hyphenate "reviewboard."

reviewboard/templates/hostingsvcs/rb-gateway/repo_hook_instructions.html (Diff revision 1)

The issue has been resolved. Show all issues

Missing </p>.

reviewboard/templates/hostingsvcs/rb-gateway/repo_hook_instructions.html (Diff revision 1)
The issue has been resolved. Show all issues
```
Let's put a $ before each command, to indicate a shell.
```

reviewboard/templates/hostingsvcs/rb-gateway/repo_hook_instructions.html (Diff revision 1)

The issue has been resolved. Show all issues

No space before systemd.

Change Summary:

Addressed the majority of feedback.

Commit:

79253340b9c2f6a710013171cd83975b5e1937ce

919d6c4db4761aa622ad8076d8219f713446fb28

Diff:

Revision 2 (+95 -1)

Show changes

	reviewboard/hostingsvcs/rbgateway.py
	reviewboard/templates/hostingsvcs/rb-gateway/repo_hook_instructions.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Addressed remaining feedback.

Commit:

919d6c4db4761aa622ad8076d8219f713446fb28

1534c8d882152f8351b642250cec8d8141bc5260

Diff:

Revision 3 (+95 -1)

Show changes

	reviewboard/hostingsvcs/rbgateway.py
	reviewboard/templates/hostingsvcs/rb-gateway/repo_hook_instructions.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (a348323)