Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
Move and modernize X509AuthMiddleware.
Review Request #9998 — Created June 4, 2018 and submitted
X509AuthMiddlewareis an old piece of code designed to authenticate
users using X.509 certificates. It was living in
reviewboard.admin.middleware, rather than
reviewboard.accounts.middleware, had some unnecessary checks, and
determined whether to process based on logic that the account backend
split is going to break. That last reason is why this change is being
made.This change fixes all that up, simplifying the code, moving it under
reviewboard.accounts, and determining the auth backend through safer
means. It also adds unit tests to ensure that authentication only
happens under the proper circumstances.
Unit tests pass.
| Description | From | Last Updated |
|---|---|---|
|
F401 'djblets.registries.errors.RegistrationError' imported but unused |
reviewbot
|
|
|
F401 'reviewboard.accounts.forms.pages.AccountPageForm' imported but unused |
reviewbot
|
|
|
F401 'reviewboard.accounts.pages.AccountPage' imported but unused |
reviewbot
|
|
|
F401 'reviewboard.accounts.pages.unregister_account_page_class' imported but unused |
reviewbot
|
|
|
F401 'reviewboard.accounts.pages.register_account_page_class' imported but unused |
reviewbot
|
|
|
F401 'reviewboard.accounts.pages.get_page_classes' imported but unused |
reviewbot
|
