Avoid error in rbtools.clients.tfs if "tf" returns 1

Review Request #9995 — Created June 1, 2018 and submitted

nattofriends
RBTools
master
828824c...
rbtools
If "tf" returns 1, the TFS client may error out with:

```
ERROR: Could not load SCM Client "tfs"
Traceback (most recent call last):
  File "[...]/rbtools/clients/__init__.py", line 397, in load_scmclients
    client = ep.load()(config=config, options=options)
  File "[...]/rbtools/clients/tfs.py", line 972, in __init__
    if 'Version Control Tool, Version 15' in tf_vc_output:
TypeError: argument of type 'NoneType' is not iterable
```

because of `none_on_ignored_error=True` immediately above.

Ran unit tests

  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

nattofriends
david
  1. 
      
  2. rbtools/clients/tfs.py (Diff revision 2)
     
     
     

    Can you format this using parens instead of the continuation character?

    if (tf_vc_output and
        'Version Control Tool, Version 15' in tf_vc_output):
        use_tf_exe = True
    
  3. 
      
nattofriends
david
  1. Ship It!
  2. 
      
nattofriends
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (31f1537)
Loading...