flake8
failed.
JSHint
passed.
flake8
-
rbtools/clients/tfs.py (Diff revision 1) Show all issues
Avoid error in rbtools.clients.tfs if "tf" returns 1
Review Request #9995 — Created June 1, 2018 and submitted
| Information | |
|---|---|
| nattofriends | |
| RBTools | |
| master | |
| 828824c... | |
| Reviewers | |
| rbtools | |
If "tf" returns 1, the TFS client may error out with:
```
ERROR: Could not load SCM Client "tfs"
Traceback (most recent call last):
File "[...]/rbtools/clients/__init__.py", line 397, in load_scmclients
client = ep.load()(config=config, options=options)
File "[...]/rbtools/clients/tfs.py", line 972, in __init__
if 'Version Control Tool, Version 15' in tf_vc_output:
TypeError: argument of type 'NoneType' is not iterable
```
because of `none_on_ignored_error=True` immediately above.
Ran unit tests
Change Summary:
[tfs-client-calling-tf 303cf80] Fix line length
Branch: |
|
||||
|---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 2 (+2 -1) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
rbtools/clients/tfs.py (Diff revision 2) Can you format this using parens instead of the continuation character?
if (tf_vc_output and 'Version Control Tool, Version 15' in tf_vc_output): use_tf_exe = True
Change Summary:
Use parentheses instead of line continuations
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+2 -1) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.