Summary

Avoid error in rbtools.clients.tfs if "tf" returns 1

Review Request #9995 — Created June 1, 2018 and submitted June 11, 2018, 5:05 p.m.

Information

Owner

nattofriends

Repository

RBTools

Branch

master

Bugs

Depends On

Commit

828824c...

Reviewers

Groups

rbtools

People

Description

If "tf" returns 1, the TFS client may error out with:

```
ERROR: Could not load SCM Client "tfs"
Traceback (most recent call last):
  File "[...]/rbtools/clients/__init__.py", line 397, in load_scmclients
    client = ep.load()(config=config, options=options)
  File "[...]/rbtools/clients/tfs.py", line 972, in __init__
    if 'Version Control Tool, Version 15' in tf_vc_output:
TypeError: argument of type 'NoneType' is not iterable
```

because of `none_on_ignored_error=True` immediately above.

Testing Done

Ran unit tests

Issues

Description	From	Last Updated
E501 line too long (83 > 79 characters)	reviewbot	June 4, 2018, 11:37 a.m.
Can you format this using parens instead of the continuation character? if (tf_vc_output and 'Version Control Tool, Version 15' in …	david	June 4, 2018, 11:35 a.m.

flake8 failed.

JSHint passed.

flake8

rbtools/clients/tfs.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (83 > 79 characters)
```

Change Summary:

[tfs-client-calling-tf 303cf80] Fix line length

Branch:

tfs-client-calling-tf

master

Commit:

ffc7a0057a2ef29588bdb915df740000d7439acc

303cf80a51a8a437a59ccea708b28d7a883681bf

Diff:

Revision 2 (+2 -1)

Show changes

rbtools/clients/tfs.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/clients/tfs.py (Diff revision 2)

The issue has been resolved. Show all issues

Can you format this using parens instead of the continuation character?

if (tf_vc_output and
    'Version Control Tool, Version 15' in tf_vc_output):
    use_tf_exe = True

Change Summary:

Use parentheses instead of line continuations

Commit:

303cf80a51a8a437a59ccea708b28d7a883681bf

828824c05ccd75e4e4a398e501e2c62240335b71

Diff:

Revision 3 (+2 -1)

Show changes

rbtools/clients/tfs.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.7.x (31f1537)