Implement password reset.

Review Request #999 — Created Aug. 25, 2009 and submitted

Information

Review Board
master
778

Reviewers

Implement password reset.

django.contrib.auth contains several views for performing a password reset in
the event that a user has forgotten their password. This change adds the various
URLs and templates to hook it up. It's visible on the login form when builtin
authentication is enabled.
Set up e-mail in my local devserver to use gmail's smtp and went through the
entire password reset process. Made sure to exercise every view/template.
chipx86
  1. 
      
    1. Made all requested changes.
  2. reviewboard/accounts/urls.py (Diff revision 1)
     
     
    Should use dashes instead of underscores for the names.
  3. reviewboard/templates/accounts/login.html (Diff revision 1)
     
     
     
     
     
    Same comment about alignments.
  4. No space before "Forgotten"
  5. Can you indent these within the template tag?
  6. Does this wrap to 80?
  7. Space spaces in the {{...}} variables.
  8. We should be consistent with the quoting on trans '...', at least within the file.
  9. Should probably put the blocktrans tags on their own lines, given the size of the text.
    
    Also, I doubt the {% url %} works here. Template tags can't nest within a {% blocktrans %}. In this case, you'll probably need to do a {% url recover as recover_url %} before the {% blocktrans %}.
  10. Please make this wrap to 80. I'd prefer a {% blocktrans %} here.
  11. No spaces in {{..}}
  12. What's uidb36?
    1. uid base 36. It's not my choice, it's django auth's.
  13. 
      
david
david
david
david
Review request changed
chipx86
  1. Looks good.
  2. 
      
Loading...