-
-
reviewboard/accounts/urls.py (Diff revision 1) Should use dashes instead of underscores for the names.
-
-
-
reviewboard/templates/accounts/password_reset_confirm.html (Diff revision 1) Can you indent these within the template tag?
-
-
reviewboard/templates/accounts/password_reset_confirm.html (Diff revision 1) Space spaces in the {{...}} variables. -
reviewboard/templates/accounts/password_reset_confirm.html (Diff revision 1) We should be consistent with the quoting on trans '...', at least within the file.
-
reviewboard/templates/accounts/password_reset_confirm.html (Diff revision 1) Should probably put the blocktrans tags on their own lines, given the size of the text. Also, I doubt the {% url %} works here. Template tags can't nest within a {% blocktrans %}. In this case, you'll probably need to do a {% url recover as recover_url %} before the {% blocktrans %}. -
reviewboard/templates/accounts/password_reset_done.html (Diff revision 1) Please make this wrap to 80. I'd prefer a {% blocktrans %} here. -
-
Implement password reset.
Review Request #999 — Created Aug. 25, 2009 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| master | |
| 778 | |
| Reviewers | |
| reviewboard | |
Implement password reset. django.contrib.auth contains several views for performing a password reset in the event that a user has forgotten their password. This change adds the various URLs and templates to hook it up. It's visible on the login form when builtin authentication is enabled.
Set up e-mail in my local devserver to use gmail's smtp and went through the entire password reset process. Made sure to exercise every view/template.
Change Summary:
Made Christian's requested changes.
Change Summary:
A few more tweaks.
Diff: |
Revision 3 (+132 -1)
|
|---|