Avoid crashes when generating PII-safe URLs without a resolver match.

Review Request #9978 — Created May 24, 2018 and submitted

Information

Djblets
release-1.0.x
537b36b...

Reviewers

When attempting to generate a PII-safe URL on 404 Not Found pages or in
other locations where a resolver match was not present,
build_pii_safe_page_url_for_request would crash, failing when
accessing an attribute of the non-existent match.

It now checks for this, falling back on an empty dictionary instead.

Tested that this fixed a crash in production.

Unit tests pass.

david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (3fd6fcd)
Loading...