Summary

Update the consent view decorator/mixin to check for policy requirements

Review Request #9976 — Created May 23, 2018 and submitted May 24, 2018, 12:44 a.m.

Information

Owner

Repository

Djblets

Branch

release-1.0.x

Bugs

Depends On

~~9948~~

Commit

cb24d21...

Reviewers

Groups

People

Description

The @check_pending_consent and CheckPendingConsentMixin now check
the registry for the presence of a PolicyConsentRequirement instance
and, if found, ensure that the policy has been accepted. If the policy
has been rejected, the decorator/mixin will redirect to the pending
consent URL.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Too many blank lines.	chipx86	May 24, 2018, 12:13 a.m.
Swap these.	chipx86	May 24, 2018, 12:13 a.m.

flake8 passed.

JSHint passed.

Ship it!

djblets/privacy/consent/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Too many blank lines.
```
djblets/privacy/consent/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Swap these.
```

Change Summary:

Addressed feedback

Commit:

-	e023416b69cc240c332384b842c5e8b1737cf577
+	cb24d211bbc03257b6a1c70a3a01d0763c0dc47b

Diff:

Revision 2 (+90 -16)

	djblets/privacy/consent/views.py
	djblets/privacy/tests/test_consent_views.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (a678caf)

Loading...