Use field_is_html flags in GravatarConsentRequirement

Review Request #9967 — Created May 22, 2018 and updated

brennie
Review Board
release-3.0.x
9965
83a8636...
reviewboard

Instead of using mark_safe directly, we now set the {field}_is_html
flag so that it will be rendered as HTML. This also corrects the issue
that the intent_description was being marked as safe immediately
after calling ugettext_lazy, which would result in the stored
attribute not being translated for users (as it already would have been
forced to go through the translation step by calling mark_safe).

Viewed the consent requirements page and saw the HTML was rendered
correctly.

Description From Last Updated

With the comment made in /r/9965/, we wouldn't need <p> in here.

chipx86chipx86
brennie
Review request changed

Testing Done:

~  

Viewed the consent requirements page and saw the HTMl was rendered

  ~

Viewed the consent requirements page and saw the HTML was rendered

    correctly.

chipx86
  1. 
      
  2. reviewboard/accounts/privacy.py (Diff revision 1)
     
     
     
     
     

    With the comment made in /r/9965/, we wouldn't need <p> in here.

  3. 
      
Loading...