Use field_is_html flags in GravatarConsentRequirement
Review Request #9967 — Created May 22, 2018 and discarded
Instead of using
mark_safe
directly, we now set the{field}_is_html
flag so that it will be rendered as HTML. This also corrects the issue
that theintent_description
was being marked as safe immediately
after callingugettext_lazy
, which would result in the stored
attribute not being translated for users (as it already would have been
forced to go through the translation step by callingmark_safe
).
Viewed the consent requirements page and saw the HTML was rendered
correctly.
Description | From | Last Updated |
---|---|---|
With the comment made in /r/9965/, we wouldn't need <p> in here. |
|
-
-
reviewboard/accounts/privacy.py (Diff revision 1) With the comment made in /r/9965/, we wouldn't need
<p>
in here.