• 
      

    Add acceptance of policies during user sign-up.

    Review Request #9962 — Created May 18, 2018 and submitted

    Information

    Review Board
    release-3.0.x
    34326e5...

    Reviewers

    This change adds a new checkbox to the account registration field to
    allow users to indicate their acceptance of the linked privacy policy
    and/or terms of service. This is shown when URLs for these are
    configured in the privacy section of the admin settings and user consent
    is turned on. When saved, the form will then create the user and record
    their acceptance of the policies using the consent requirement.

    Verified the display of the form with various configurations (consent
    turned on/off, policies linked or not). Saw that when the field was
    visible, it was required, and creating a user would then immediately
    redirect to the privacy consent page with the policies marked as
    accepted.


    Description From Last Updated

    We should have unit tests for policy text and acceptance.

    chipx86 chipx86

    Can you attach a screenshot?

    chipx86 chipx86

    Due to Python's weird ternary operator-like thing, this evaluates to a string, not a bool.

    chipx86 chipx86

    I think most sites use Title Case for Privacy Policy and Terms of Service. We should do the same in …

    chipx86 chipx86
    chipx86
    1. 
        
    2. Show all issues

      We should have unit tests for policy text and acceptance.

      1. We don't have any testing infrastructure for user registration right now. Given the list of things left to do this week I'm going to defer this.

    3. Show all issues

      Can you attach a screenshot?

    4. reviewboard/accounts/mixins.py (Diff revision 1)
       
       
       
       
      Show all issues

      Due to Python's weird ternary operator-like thing, this evaluates to a string, not a bool.

    5. reviewboard/accounts/mixins.py (Diff revision 1)
       
       
       
      Show all issues

      I think most sites use Title Case for Privacy Policy and Terms of Service. We should do the same in all these.

    6. 
        
    david
    david
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (db81d1e)