Summary

Make the login box prettier

Review Request #996 — Created Aug. 25, 2009 and submitted

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Make the login box prettier

One of the areas we've long ignored is our login and settings pages. This change
is the first small step towards a revamp. This isn't super pretty yet because I
suck at making web pages pretty right now, but it's an improvement in the
design.

Testing Done

Screenshots

Tweaked login form

reviewboard/templates/accounts/login.html (Diff revision 1)

This shouldn't be here. <table> is a block element, so it wouldn't belong in a <p>, and it's not closed anyway. If you need vertical spacing, you should use CSS.

reviewboard/templates/accounts/login.html (Diff revision 1)

Template tags should be indented to line 0, with whitespace inside of it for the indentation of the commands.

reviewboard/templates/accounts/login.html (Diff revision 1)

Can you align the <td> elements with the other <td>s in the table?

reviewboard/templates/accounts/login.html (Diff revision 1)

Should use {% url register %} instead of saving and using the variable.

reviewboard/templates/accounts/login.html (Diff revision 1)
```
Should just go on the same line.
```

Summary:: Make the login form prettier
Make the login box prettier
Description:: ~
One of the areas we've long ignored is our login and settings pages. This change is the first small step towards a revamp. This isn't super pretty yet because I suck at making web pages pretty right now, but it's an improvement in the design.
~
Make the login box prettier
+
+
One of the areas we've long ignored is our login and settings pages. This change
+ is the first small step towards a revamp. This isn't super pretty yet because I
+ suck at making web pages pretty right now, but it's an improvement in the
+ design.

Change Summary:

Made changes requested by Christian.

Diff:

Revision 2 (+24 -18)

Show changes

	reviewboard/accounts/urls.py
	reviewboard/htdocs/media/rb/css/common.css
	reviewboard/templates/accounts/login.html

Ship it!

```
Looks goof.
```

~		One of the areas we've long ignored is our login and settings pages. This change is the first small step towards a revamp. This isn't super pretty yet because I suck at making web pages pretty right now, but it's an improvement in the design.
	~	Make the login box prettier
	+
	+	One of the areas we've long ignored is our login and settings pages. This change
	+	is the first small step towards a revamp. This isn't super pretty yet because I
	+	suck at making web pages pretty right now, but it's an improvement in the
	+	design.