Port UserProfileAvatarSettingsManager from Review Board

Review Request #9951 — Created May 16, 2018 and updated

brennie
Djblets
release-1.0.x
9950
9952
5a40583...
djblets

This patch is a direct port of the UserProfileAvatarSettingsManager
from Review Board with a number of added unit tests.

Ran unit tests on Django 1.6.11 and Django 1.8.19.

Description From Last Updated

Is this something that can wait until after the upcoming release? Worried about all the last-minute changes. It's going to ...

chipx86chipx86

It was already like this, but services before settings

daviddavid

I feel like this would be better done in the change that allows using it on classes. In this change ...

daviddavid

Why is this needed? The database should be reset for each test. This is also missing a super() call.

chipx86chipx86
david
  1. 
      
  2. djblets/avatars/tests.py (Diff revision 1)
     
     
     
     
     
     
     

    It was already like this, but services before settings

  3. djblets/avatars/tests.py (Diff revision 1)
     
     

    I feel like this would be better done in the change that allows using it on classes. In this change it's just noise.

  4. 
      
brennie
Review request changed

Change Summary:

Addressed feedback.

Commit:

-65740eb3ca2a4010e9f19eacf97eed372ab6aeb0
+5a40583b0cab83a478c88cc7febc876db0afa8f2

Diff:

Revision 2 (+210 -1)

Show changes

Checks run (1 succeeded, 1 failed with error)

flake8 internal error.
JSHint passed.
chipx86
  1. 
      
  2. Is this something that can wait until after the upcoming release? Worried about all the last-minute changes. It's going to be hard to test in time.

  3. djblets/avatars/tests.py (Diff revision 2)
     
     
     

    Why is this needed? The database should be reset for each test.

    This is also missing a super() call.

  4. 
      
Loading...