flake8
internal error.
JSHint
passed.
Port UserProfileAvatarSettingsManager from Review Board
Review Request #9951 — Created May 16, 2018 and discarded
This patch is a direct port of the
UserProfileAvatarSettingsManager
from Review Board with a number of added unit tests.
Ran unit tests on Django 1.6.11 and Django 1.8.19.
| Description | From | Last Updated |
|---|---|---|
|
Is this something that can wait until after the upcoming release? Worried about all the last-minute changes. It's going to … |
 chipx86
|
|
|
It was already like this, but services before settings |
 david
|
|
|
I feel like this would be better done in the change that allows using it on classes. In this change … |
david
|
|
|
Why is this needed? The database should be reset for each test. This is also missing a super() call. |
chipx86
|
-
-
-
djblets/avatars/tests.py (Diff revision 1) I feel like this would be better done in the change that allows using it on classes. In this change it's just noise.
Change Summary:
Addressed feedback.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+210 -1) |
Checks run (1 succeeded, 1 failed with error)
flake8
internal error.
JSHint
passed.
-
-
Is this something that can wait until after the upcoming release? Worried about all the last-minute changes. It's going to be hard to test in time.
-
djblets/avatars/tests.py (Diff revision 2) Why is this needed? The database should be reset for each test.
This is also missing a
super()call.