Summary

Port UserProfileAvatarSettingsManager from Review Board

Review Request #9951 — Created May 16, 2018 and discarded Oct. 26, 2021, 12:13 p.m.

Information

Owner

brennie

Repository

Djblets

Branch

release-1.0.x

Bugs

Depends On

~~9950~~

Blocks

9952

Reviewers

Groups

djblets

People

Description

This patch is a direct port of the UserProfileAvatarSettingsManager
from Review Board with a number of added unit tests.

Testing Done

Ran unit tests on Django 1.6.11 and Django 1.8.19.

Issues

Description	From	Last Updated
Is this something that can wait until after the upcoming release? Worried about all the last-minute changes. It's going to …	chipx86	May 23, 2018, 12:57 a.m.
It was already like this, but services before settings	david	May 21, 2018, 5:21 p.m.
I feel like this would be better done in the change that allows using it on classes. In this change …	david	May 21, 2018, 5:19 p.m.
Why is this needed? The database should be reset for each test. This is also missing a super() call.	chipx86	May 23, 2018, 12:57 a.m.

flake8 internal error.

JSHint passed.

djblets/avatars/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
It was already like this, but services before settings
```

djblets/avatars/tests.py (Diff revision 1)

The issue has been resolved. Show all issues

I feel like this would be better done in the change that allows using it on classes. In this change it's just noise.

Change Summary:

Addressed feedback.

Commit:

65740eb3ca2a4010e9f19eacf97eed372ab6aeb0

5a40583b0cab83a478c88cc7febc876db0afa8f2

Diff:

Revision 2 (+210 -1)

Show changes

	djblets/avatars/tests.py
	djblets/avatars/settings/__init__.py
	djblets/avatars/settings.py
	djblets/avatars/settings/profile.py

Checks run (1 succeeded, 1 failed with error)

flake8 internal error.

JSHint passed.

Fix it!

An issue was opened. Show all issues

Is this something that can wait until after the upcoming release? Worried about all the last-minute changes. It's going to be hard to test in time.

djblets/avatars/tests.py (Diff revision 2)

An issue was opened. Show all issues

Why is this needed? The database should be reset for each test.

This is also missing a super() call.

Status:: Discarded