• 
      

    Port UserProfileAvatarSettingsManager from Review Board

    Review Request #9951 — Created May 17, 2018 and discarded

    Information

    Djblets
    release-1.0.x

    Reviewers

    This patch is a direct port of the UserProfileAvatarSettingsManager
    from Review Board with a number of added unit tests.

    Ran unit tests on Django 1.6.11 and Django 1.8.19.

    Description From Last Updated

    Is this something that can wait until after the upcoming release? Worried about all the last-minute changes. It's going to …

    chipx86chipx86

    It was already like this, but services before settings

    daviddavid

    I feel like this would be better done in the change that allows using it on classes. In this change …

    daviddavid

    Why is this needed? The database should be reset for each test. This is also missing a super() call.

    chipx86chipx86
    david
    1. 
        
    2. djblets/avatars/tests.py (Diff revision 1)
       
       
       
       
       
       
       
      Show all issues

      It was already like this, but services before settings

    3. djblets/avatars/tests.py (Diff revision 1)
       
       
      Show all issues

      I feel like this would be better done in the change that allows using it on classes. In this change it's just noise.

    4. 
        
    brennie
    chipx86
    1. 
        
    2. Show all issues

      Is this something that can wait until after the upcoming release? Worried about all the last-minute changes. It's going to be hard to test in time.

    3. djblets/avatars/tests.py (Diff revision 2)
       
       
       
      Show all issues

      Why is this needed? The database should be reset for each test.

      This is also missing a super() call.

    4. 
        
    david
    Review request changed
    Status:
    Discarded