flake8
passed.
JSHint
passed.
Review Request #9940 — Created May 15, 2018 and submitted
A change in the
rbtools patch
support a while back regressed the
behaviour of the-p
flag that is passed to patch(1). We now no longer
assume that is anint
and just splat it into the string to avoid a
TypeError whenp
is a string like'4'
.
Ran unit tests.
Description | From | Last Updated |
---|---|---|
We should convert to int before doing this check, no? '-1' >= 0 returns True. Alternatively, I think this is … |
david |
rbtools/clients/__init__.py (Diff revision 1) |
---|
We should convert to int before doing this check, no?
'-1' >= 0
returnsTrue
.Alternatively, I think this is effectively a
None
check, so this can probably beif p_num is not None
.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+11 -2) |