Summary

Avoid TypeError while coercing string to int

Review Request #9940 — Created May 15, 2018 and submitted May 21, 2018, 5:23 p.m.

Information

Owner

Repository

RBTools

Branch

release-1.0.x

Bugs

4364

Depends On

Commit

be2c67d...

Reviewers

Groups

People

Description

A change in the rbtools patch support a while back regressed the
behaviour of the -p flag that is passed to patch(1). We now no longer
assume that is an int and just splat it into the string to avoid a
TypeError when p is a string like '4'.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
We should convert to int before doing this check, no? '-1' >= 0 returns True. Alternatively, I think this is …	david	May 15, 2018, 3:07 p.m.

flake8 passed.

JSHint passed.

rbtools/clients/__init__.py (Diff revision 1)

The issue has been resolved. Show all issues

We should convert to int before doing this check, no? '-1' >= 0 returns True.

Alternatively, I think this is effectively a None check, so this can probably be if p_num is not None.

Commit:

a6563a1d5b1aa136a35095113c68e5318ca030e9

be2c67d278311328e087a69a368452b4fd2293a5

Diff:

Revision 2 (+11 -2)

rbtools/clients/__init__.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.0.x (cffad86)