Change Summary:
Accidentally clobbered needed import.
Description: |
|
|||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+190 -47) |
Review Request #993 — Created Aug. 24, 2009 and discarded
Information | |
---|---|
helder | |
Review Board | |
Reviewers | |
reviewboard | |
Allows admin to add multiple webhook URLs. These are POSTed to on publish events, with a JSON payload of: - event_name (only "post_publish" for now) - event_source (model instance that got published) - event_source_type (model class: reviewrequest, review) - changedesc (when available) TODO: - write micro test app using wsgi to receive POSTs
Ran test suite with a webhook pointing at http://www.postbin.org/14iso90 and everything worked fine.
Accidentally clobbered needed import.
Description: |
|
|||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+190 -47) |
reviewboard/notifications/email.py (Diff revision 2) |
---|
Should be: sender is ReviewRequest. Same with the others.
reviewboard/webapi/json.py (Diff revision 2) |
---|
Please, since you are already touching imports, alphabetize this :)