Site-wide webhooks

Review Request #993 — Created Aug. 24, 2009 and discarded

Information
helder
Review Board
Reviewers
reviewboard 
Allows admin to add multiple webhook URLs. These are POSTed to on publish events, with a JSON payload of:

 - event_name (only "post_publish" for now)
 - event_source (model instance that got published)
 - event_source_type (model class: reviewrequest, review)
 - changedesc (when available)

TODO:

- write micro test app using wsgi to receive POSTs
Ran test suite with a webhook pointing at http://www.postbin.org/14iso90 and everything worked fine.
HE
chipx86
chipx86 
  1. Hey Helder,

Sorry for the delay in this. Things have been crazy here...

This is looking awesome. Just a few things and then it's ready!
  2. reviewboard/notifications/email.py (Diff revision 2) 
     
     
     
    Should be: sender is ReviewRequest. Same with the others.
  3. "This is"
  4. reviewboard/notifications/event_manager.py (Diff revision 2) 
     
     
     
     
    "- to be done -" ?
    1. Yeah, email so far isn't being delivered through event_manager. I have to adapt the email stuff to implement a dispatch() method like the Webhook class.
  5. reviewboard/notifications/models.py (Diff revision 2) 
     
     
     
    Can you add a docstring for this?
  6. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    7. 




  

 
















 





 

  

   




edufelipe




   

   





  

 



 

  


   

   

    
 
edufelipe


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      reviewboard/reviews/models.py
      


       (Diff revision 2)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    




    
    This should be alphabetically ordered.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      reviewboard/webapi/json.py
      


       (Diff revision 2)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    




    
    Please, since you are already touching imports, alphabetize this :)
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  4. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  

 
















 



 

  

   





 HE





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Discarded

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...