Summary

Site-wide webhooks

Review Request #993 — Created Aug. 24, 2009 and discarded Sept. 28, 2012, 8:29 p.m.

Information

Owner

helder

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Allows admin to add multiple webhook URLs. These are POSTed to on publish events, with a JSON payload of:

 - event_name (only "post_publish" for now)
 - event_source (model instance that got published)
 - event_source_type (model class: reviewrequest, review)
 - changedesc (when available)

TODO:

- write micro test app using wsgi to receive POSTs

Testing Done

Ran test suite with a webhook pointing at http://www.postbin.org/14iso90 and everything worked fine.

Change Summary:

Accidentally clobbered needed import.

Description:

		Allows admin to add multiple webhook URLs. These are POSTed to on publish events, with a JSON payload of:

~		event_type (only publish for now)
	~	event_name (only "post_publish" for now)
		event_source (model instance that got published)
		event_source_type (model class: reviewrequest, review)
		changedesc (when available)

		TODO:

		write micro test app using wsgi to receive POSTs

Diff:

Revision 2 (+190 -47)

Show changes

	reviewboard/settings.py
	reviewboard/notifications/__init__.py
	reviewboard/notifications/admin.py
	reviewboard/notifications/email.py
	reviewboard/notifications/event_manager.py
	reviewboard/notifications/models.py
	reviewboard/notifications/post_url_dispatcher.py
	reviewboard/reviews/models.py
	3 more

Hey Helder,

Sorry for the delay in this. Things have been crazy here...

This is looking awesome. Just a few things and then it's ready!

reviewboard/notifications/email.py (Diff revision 2)

Should be: sender is ReviewRequest. Same with the others.

reviewboard/notifications/event_manager.py (Diff revision 2)
```
"This is"
```

reviewboard/notifications/event_manager.py (Diff revision 2)

"- to be done -" ?

helder

Sept. 19, 2009, 10:33 p.m.

Yeah, email so far isn't being delivered through event_manager. I have to adapt the email stuff to implement a dispatch() method like the Webhook class.

reviewboard/notifications/models.py (Diff revision 2)
```
Can you add a docstring for this?
```

reviewboard/reviews/models.py (Diff revision 2)

This should be alphabetically ordered.

reviewboard/webapi/json.py (Diff revision 2)

Please, since you are already touching imports, alphabetize this :)

Status:: Discarded