Change Summary:
This latest diff adds validation of the username regex entered in siteconfig form, and modifies X509Middleware to not execute any code if the X.509 authentication backend is disabled.
Diff: |
Revision 2 (+174 -11) |
|---|
Adds ability to use x.509 certificates for authenticating users
Review Request #991 — Created Aug. 24, 2009 and submitted
These changes enable Review Board to use x.509 certificates to be used alongside the builtin username/password authentication backend. This functionality will be useful for deployments in environments with a Public Key Infrastructure set up. I deliberately avoided modifying post-review to support client certificates due to a lack of decent support for them in Python's high-level libraries. Instead, I modified the user preferences view to permit authenticated users to set their Django password. Django's built-in support for multiple authentication backends will then permit them to use the builtin auth backend with post-review. This diff was originally reviewed at http://reviews.review-board.org/r/938/
Tested on my test Review Board server, running Apache/mod_python,mod_ssl/Django 1.1.
NH
-
-
-
reviewboard/accounts/backends.py (Diff revision 2) Wondering if we actually need to check for this. Presumably, if this code is even running, then this auth backend is configured. Otherwise it shouldn't be in the list.
-
reviewboard/admin/forms.py (Diff revision 2) Can we say where the field is from? "The [something] field" maybe.
-
-
reviewboard/admin/forms.py (Diff revision 2) I believe you have to return the data from this function if it's valid.
-
reviewboard/admin/middleware.py (Diff revision 2) It's possible that we may get something down the road that is actually a subclass of this request type, rather than being that request type itself. For this reason, I think it may be better if we import these classes directly and use isinstance() to check.
-
reviewboard/admin/middleware.py (Diff revision 2) It'd be really nice if we didn't have to access _req directly. Can we use os.getenv()? It looks like ModPythonHandler actually copies _req.subprocess_env into os.environ.
-
reviewboard/admin/middleware.py (Diff revision 2) If this is ever not a string, then the user did something custom and stupid, and we don't want to mask it. We probably shouldn't use str() here.
NH