Summary

Limit multi-commit review requests to repositories that support them

Review Request #9883 — Created April 20, 2018 and submitted Aug. 27, 2018, 5:04 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

~~9852~~

Blocks

9889

Commit

69fdb9d...

Reviewers

Groups

reviewboard

People

Description

SCMTools now have a supports_history flag that indicates whether or
not they support multi-commit review requests. The API now prevents
creating a review request with history when the underlying SCMTool does
not support it.

For now, only Git will have the support enabled (althrough incomplete)
until the overall DVCS support is feature complete and then support for
other SCMs can be added.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
F811 redefinition of unused 'test_post_create_with_history_enabled_unsupported_tool' from line 1263	reviewbot	April 20, 2018, 7:01 p.m.
Looks like this line wasn't supposed to be deleted.	david	May 2, 2018, 3:39 p.m.

flake8 passed.

JSHint passed.

Change Summary:

More tests.

Commit:

-	1266b03c5b7dbf1eeb165753079f317b74a08fe2
+	640d178ff1d34c0f420807a89b1c857e26cbc894

Diff:

Revision 2 (+64 -4)

Show changes

	reviewboard/reviews/managers.py
	reviewboard/scmtools/core.py
	reviewboard/scmtools/git.py
	reviewboard/testing/scmtool.py
	reviewboard/webapi/tests/test_review_request.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/tests/test_review_request.py (Diff revision 2)

Show all issues

F811 redefinition of unused 'test_post_create_with_history_enabled_unsupported_tool' from line 1263

Change Summary:

Rebase and fix test name.

Commit:

-	640d178ff1d34c0f420807a89b1c857e26cbc894
+	2c8aeff52b0f5ad79a64aac04ed4acd5b13063e9

Diff:

Revision 3 (+60 -1)

Show changes

	reviewboard/reviews/managers.py
	reviewboard/scmtools/core.py
	reviewboard/scmtools/git.py
	reviewboard/testing/scmtool.py
	reviewboard/webapi/tests/test_review_request.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/scmtools/core.py (Diff revision 3)
Show all issues
```
Looks like this line wasn't supposed to be deleted.
```

Change Summary:

Addressed David's feedback.

Commit:

-	2c8aeff52b0f5ad79a64aac04ed4acd5b13063e9
+	2a577aabbb078aff54ff9cbeff6f4fbbab5b28a0

Diff:

Revision 4 (+60)

Show changes

	reviewboard/reviews/managers.py
	reviewboard/scmtools/core.py
	reviewboard/scmtools/git.py
	reviewboard/testing/scmtool.py
	reviewboard/webapi/tests/test_review_request.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Add Tool.supports_history

Commit:

-	2a577aabbb078aff54ff9cbeff6f4fbbab5b28a0
+	c25450884a553d52c603bbb7ea634a5617bb8201

Diff:

Revision 5 (+62)

Show changes

	reviewboard/reviews/managers.py
	reviewboard/scmtools/core.py
	reviewboard/scmtools/git.py
	reviewboard/scmtools/models.py
	reviewboard/testing/scmtool.py
	reviewboard/webapi/tests/test_review_request.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Commit:

-	c25450884a553d52c603bbb7ea634a5617bb8201
+	69fdb9dbe5a8a223e0b4ca017f7a754ea341460d

Diff:

Revision 6 (+62)

Show changes

	reviewboard/reviews/managers.py
	reviewboard/scmtools/core.py
	reviewboard/scmtools/git.py
	reviewboard/scmtools/models.py
	reviewboard/testing/scmtool.py
	reviewboard/webapi/tests/test_review_request.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (57c01fc)