Limit multi-commit review requests to repositories that support them

Review Request #9883 — Created April 20, 2018 and updated

brennie
Review Board
release-4.0.x
9852
9889
c254508...
reviewboard

SCMTools now have a supports_history flag that indicates whether or
not they support multi-commit review requests. The API now prevents
creating a review request with history when the underlying SCMTool does
not support it.

For now, only Git will have the support enabled (althrough incomplete)
until the overall DVCS support is feature complete and then support for
other SCMs can be added.

Ran unit tests.

  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
brennie
Review request changed

Change Summary:

More tests.

Commit:

-1266b03c5b7dbf1eeb165753079f317b74a08fe2
+640d178ff1d34c0f420807a89b1c857e26cbc894

Diff:

Revision 2 (+64 -4)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

brennie
david
  1. 
      
  2. reviewboard/scmtools/core.py (Diff revision 3)
     
     

    Looks like this line wasn't supposed to be deleted.

  3. 
      
brennie
brennie
Review request changed

Change Summary:

Add Tool.supports_history

Commit:

-2a577aabbb078aff54ff9cbeff6f4fbbab5b28a0
+c25450884a553d52c603bbb7ea634a5617bb8201

Diff:

Revision 5 (+62)

Show changes

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
david
  1. Ship It!
  2. 
      
Loading...