flake8
-
reviewboard/hostingsvcs/testing/testcases.py (Diff revision 1)
Review Request #9857 — Created April 4, 2018 and submitted
These new utilities make it easier to test HTTP requests and responses
dealing with multiple paths, and simple responses payloads or errors
with custom headers. It does this through amake_handler_for_paths()
function that takes in a dictionary of information and returns a method
to pass tosetup_http_test()
.It also adds a
dump_json()
method that wrapsjson.dumps()
and
returns a bytestring, helping deal with Python 2/3 compatibility.
Used these new methods in upcoming unit tests, which pass.
Removed an extra space.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+105 -12) |
reviewboard/hostingsvcs/testing/testcases.py (Diff revision 2) |
---|
It's probably slightly more correct to say an HTTP handler
Changed "a" to "an" in a docstring.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+105 -12) |
reviewboard/hostingsvcs/testing/testcases.py (Diff revision 3) |
---|
This doesn't need the
None
check:if not isinstance(payload, bytes):