Link to LocalSite user pages from LocalSite datagrids

Review Request #9855 — Created April 4, 2018 and submitted

brennie
Review Board
release-3.0.x
bfa839f...
reviewboard

A change a while back upgraded the UsernameColumn to use the new
link_func functionality of Djblets datagrids. However, it regressed
the created URL to the absolute URL of the user (which always lives in
the global namespace) instead of the per-LocalSite URL when viewing a
datagrid on a LocalSite. This change fixes that issue.

Ran unit tests.
Viewed a datagrid on a LocalSite and saw the correct URL for the
username column.

Description From Last Updated

Looks good, but can you add unit tests for this?

chipx86chipx86

Update testing done to indicate that the tests pass and then I'm happy.

daviddavid

F401 'reviewboard.site.models.LocalSite' imported but unused

reviewbotreviewbot
chipx86
  1. 
      
  2. Looks good, but can you add unit tests for this?

  3. 
      
brennie
Review request changed

Change Summary:

Unit tests!

Commit:

-30793b716ac2828c3f0f990bbdd5fb55ec4a1f60
+918a92e463eec65d406576a4020889b376d7c6dc

Diff:

Revision 2 (+32 -2)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

brennie
david
  1. 
      
  2. Update testing done to indicate that the tests pass and then I'm happy.

  3. 
      
brennie
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (e9a9988)
Loading...