Summary

Link to LocalSite user pages from LocalSite datagrids

Review Request #9855 — Created April 4, 2018 and submitted April 4, 2018, 3:40 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

bfa839f...

Reviewers

Groups

reviewboard

People

Description

A change a while back upgraded the UsernameColumn to use the new
link_func functionality of Djblets datagrids. However, it regressed
the created URL to the absolute URL of the user (which always lives in
the global namespace) instead of the per-LocalSite URL when viewing a
datagrid on a LocalSite. This change fixes that issue.

Testing Done

Ran unit tests.
Viewed a datagrid on a LocalSite and saw the correct URL for the
username column.

Issues

Description	From	Last Updated
Looks good, but can you add unit tests for this?	chipx86	April 4, 2018, 2:48 p.m.
Update testing done to indicate that the tests pass and then I'm happy.	david	April 4, 2018, 3:39 p.m.
F401 'reviewboard.site.models.LocalSite' imported but unused	reviewbot	April 4, 2018, 2:49 p.m.

flake8 passed.

JSHint passed.

Show all issues

Looks good, but can you add unit tests for this?

Change Summary:

Unit tests!

Commit:

-	30793b716ac2828c3f0f990bbdd5fb55ec4a1f60
+	918a92e463eec65d406576a4020889b376d7c6dc

Diff:

Revision 2 (+32 -2)

Show changes

	reviewboard/datagrids/columns.py
	reviewboard/datagrids/tests.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/datagrids/tests.py (Diff revision 2)

Show all issues

F401 'reviewboard.site.models.LocalSite' imported but unused

Change Summary:

Flake8

Commit:

-	918a92e463eec65d406576a4020889b376d7c6dc
+	bfa839f7506937689611fb0fc7f3a5260f451451

Diff:

Revision 3 (+31 -2)

Show changes

	reviewboard/datagrids/columns.py
	reviewboard/datagrids/tests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

Show all issues

Update testing done to indicate that the tests pass and then I'm happy.

Testing Done:

~		Viewed a datagrid on a LocalSite and saw the correct URL for the
	~	Ran unit tests.
	+	Viewed a datagrid on a LocalSite and saw the correct URL for the
		username column.

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (e9a9988)