Fix regressions in auto-sizing of text fields for the review request page.

Review Request #9853 — Created April 3, 2018 and submitted

Information

Review Board
release-3.0.x
d24b68f...

Reviewers

The text fields (Description and Testing Done) on the review request
page are meant to grow as you add content and shrink as you remove it.

This regressed in 3.0 with the field rework due to the "resize" event
not making it up to the field. RB.TextEditorView was emitting the
event, but RB.InlineEditorView wasn't passing it up, and neither was
RB.ReviewRequestFields.TextFieldView.

Chaining these events up to TextFieldView ensures that layout
calculation will take place as content is added to or removed from the
text field, restoring the ability to auto-size the field.

Manually tested that this fixed issues with auto-resizing the text fields
on RBCommons.

Unit tests pass.

david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (b0bcd8a)
Loading...