Summary

Prevent .retina() from overriding other background attributes.

Review Request #9844 — Created March 28, 2018 and submitted March 29, 2018, 10:05 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-1.0.x

Bugs

Depends On

Commit

d5aa886...

Reviewers

Groups

djblets

People

Description

The new .retina() LessCSS mixin was setting background: instead of
background-image:. This caused other CSS rules, like
background-repeat:, to be overridden, regressing behavior.

It now sets background-image: explicitly.

Testing Done

Tested with existing icons. Didn't see any regressions.

Tested with the Intercom chat bubble icon on RBCommons. It was no longer
repeating weirdly.

flake8 passed.

JSHint passed.

Expand All
Collapse All

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (d53ae3c)