- Download Diff

Summary:

Fix communication between RB and RB Gateway

Review Request #9839 — Created March 27, 2018 and submitted April 6, 2018, 1:30 p.m.

Information
Owner:	brennie
Repository:	rb-gateway
Branch:	master
Bugs:
Depends On:	~~9834~~
Blocks:	9841
Commit:	952b0d7...
Reviewers
Groups:	rb-gateway
People:

Description

Review Board's RB Gateway support requires POSTing to the /session API

(even though it doesn't actually post any form data -- it just passes an

Authorization header).
Also, the /repos/<repo>/path endpoint was mistakenly removed because it

does not return useful information. However, Review Board GETs this to

determine if authorization was successful, so I've added it back.

Testing Done


Ran unit tests.
Able to authorize in Review Board.

Issues

0
0
1
0
All Issues: 1

Description	From	Last Updated
typo: hte	david	March 29, 2018, 3:54 p.m.

flake8 passed.

JSHint passed.

Depends On:

-	~~9782 - Remove reliance on global state~~
+	~~9834 - Prevent concurrent read and writes to the API config~~

Change Summary:

Rebasing all patches.

Commit:

-	67227c93411a4152ab2e58b6a0b6621e43e99d1b
+	a10d24a08c9695339b2e89fd21daff98a6a41868

Diff:

Revision 2 (+1 -1)

Show changes

api/api.go

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Summary:

-	Support POST for the session API
+	Fix communication between RB and RB Gateway

Description:

		Review Board's RB Gateway support requires POSTing to the `/session` API
		(even though it doesn't actually post any form data -- it just passes an
		`Authorization` header).
	+
	+	Also, the `/repos/<repo>/path` endpoint was mistakenly removed because it
	+	does not return useful information. However, Review Board GETs this to
	+	determine if authorization was successful, so I've added it back.

Testing Done:

		Ran unit tests.
~		Able to request a new session in Review Board.
	~	Able to authorize in Review Board.

Commit:

-	a10d24a08c9695339b2e89fd21daff98a6a41868
+	34a6e73dd78b262c24d7d6b1b57006cdf2f18a90

Diff:

Revision 3 (+15 -1)

Show changes

	api/api.go
	api/routes.go

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

api/routes.go (Diff revision 3)
Show all issues
```
typo: hte
```

Change Summary:

Fixed David's issues.

Commit:

-	34a6e73dd78b262c24d7d6b1b57006cdf2f18a90
+	952b0d7bff1ab609bd3e2afb64c4737712f70611

Diff:

Revision 4 (+15 -1)

Show changes

	api/api.go
	api/routes.go

Checks run (2 timed out)

flake8 timed out.

JSHint timed out.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (ee1caf9)

You have a pending review.

Review Board 4.0 alpha 0 (dev)

Fix communication between RB and RB Gateway

Depends On:

Change Summary:

Commit:

Diff:

Checks run (2 succeeded)

Summary:

Description:

Testing Done:

Commit:

Diff:

Checks run (2 succeeded)

Change Summary:

Commit:

Diff:

Checks run (2 timed out)

Status: Closed (submitted)

Change Summary:

api/routes.go (Diff revision 3)