Create and dispatch to site-wide webhooks

Review Request #983 — Created Aug. 21, 2009 and discarded

Information

Review Board SVN (deprecated)

Reviewers

MOVED!

This review request is now at: http://reviews.review-board.org/r/993/


(This is a preliminary code drop; needs more stuff to be ready)
Allows admin to add multiple webhook URLs. These are dispatched to on publish events, with a payload of the published object and of the changedesc, when available.

TODO:

- write micro test app using djng to receive POSTs
Ran test suite with a webhook pointing at http://www.postbin.org/14iso90 and everything worked fine.
HE
HE
HE
HE
chipx86
  1. 
      
  2. /trunk/reviewboard/notifications/admin.py (Diff revision 4)
     
     
     
     
    No blank line here.
  3. /trunk/reviewboard/notifications/event_manager.py (Diff revision 4)
     
     
     
     
     
    Should only be one blank line.
  4. This will only work for Python 2.6. We need to use django's simplejson otherwise.
     
    Though, I don't see this used anywhere.
  5. This doesn't at all seem tied to the Webhook class.
    
    Would be nice to have a doc block for this.
  6. Should be separate imports.
  7. You should log this instead.
  8. Instead of the inline if/else, please do:
    
    if not params:
        params = None
    
    urllib2.urlopen(...)
    
  9. Should also log.
  10. /trunk/reviewboard/settings.py (Diff revision 4)
     
     
    Should be added in the list alphabetically.
  11. /trunk/reviewboard/signals.py (Diff revision 4)
     
     
    Now that the other change is in, you should update this change.
  12. 
      
HE
HE
Review request changed

Change Summary:

MOVED.

Description:

  +

MOVED!

  +
  +

This review request is now at: http://reviews.review-board.org/r/993/

  +
  +

  +
   

(This is a preliminary code drop; needs more stuff to be ready)

    Allows admin to add multiple webhook URLs. These are dispatched to on publish events, with a payload of the published object and of the changedesc, when available.

   
   

TODO:

   
   
  • write micro test app using djng to receive POSTs
Loading...