Summary:

Create and dispatch to site-wide webhooks

Review Request #983 — Created Aug. 21, 2009 and discarded

Information
Owner:	helder
Repository:	Review Board SVN (deprecated)
Branch:
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

MOVED!

This review request is now at: http://reviews.review-board.org/r/993/


(This is a preliminary code drop; needs more stuff to be ready)
Allows admin to add multiple webhook URLs. These are dispatched to on publish events, with a payload of the published object and of the changedesc, when available.

TODO:

- write micro test app using djng to receive POSTs

Testing Done

Ran test suite with a webhook pointing at http://www.postbin.org/14iso90 and everything worked fine.

Change Summary:

- write serialization layout for Changedesc inside ReviewBoardAPIEncoder
- use djblets serialization for the payload (needs this patch: http://reviews.review-board.org/r/982/ )

Diff:

Revision 2 (+213 -18)

Show changes

	/trunk/reviewboard/settings.py
	/trunk/reviewboard/signals.py
	/trunk/reviewboard/urls.py
	/trunk/reviewboard/admin/urls.py
	/trunk/reviewboard/admin/views.py
	/trunk/reviewboard/notifications/__init__.py
	/trunk/reviewboard/notifications/email.py
	/trunk/reviewboard/notifications/event_manager.py
	8 more

Change Summary:

updated TODO list.

Description:

		(This is a preliminary code drop; needs more stuff to be ready)
		Allows admin to add multiple webhook URLs. These are dispatched to on publish events, with a payload of the published object and of the changedesc, when available.

~		TODO:
~		- write serialization layout for Changedesc inside ReviewBoardAPIEncoder
~		- use djblets serialization for the payload (needs this patch http://reviews.review-board.org/r/982/)
~		- integrate interface for adding webhooks into the normal admin interface
	~	TODO:
	~
	~	integrate interface for adding webhooks into the normal admin interface (currently it's a naked form at /settings/notifications)
	~	write micro test app using djng to receive POSTs
-		- write micro test app using djng to receive POSTs

Change Summary:

- integrate interface for adding webhooks into the normal admin interface (it was a naked form at /settings/notifications)

Description:

		(This is a preliminary code drop; needs more stuff to be ready)
		Allows admin to add multiple webhook URLs. These are dispatched to on publish events, with a payload of the published object and of the changedesc, when available.

		TODO:

~		integrate interface for adding webhooks into the normal admin interface (currently it's a naked form at /settings/notifications)
	~	write micro test app using djng to receive POSTs
-		write micro test app using djng to receive POSTs

Diff:

Revision 3 (+8062 -1024)

Show changes

	/trunk/reviewboard/scmtools/evolutions/repository_raw_file_url.py
	/trunk/reviewboard/scmtools/management/__init__.py
	/trunk/reviewboard/scmtools/management/commands/registerscmtools.py
	/trunk/reviewboard/templates/notifications/email_base.html
	/trunk/reviewboard/templates/notifications/email_diff_comment_fragment.html
	/trunk/reviewboard/templates/notifications/reply_email.html
	/trunk/reviewboard/templates/notifications/reply_email.txt
	/trunk/reviewboard/templates/notifications/review_email.html
	161 more

Change Summary:

This is the right diff.

Diff:

Revision 4 (+198 -18)

Show changes

	/trunk/reviewboard/settings.py
	/trunk/reviewboard/signals.py
	/trunk/reviewboard/urls.py
	/trunk/reviewboard/notifications/__init__.py
	/trunk/reviewboard/notifications/admin.py
	/trunk/reviewboard/notifications/email.py
	/trunk/reviewboard/notifications/event_manager.py
	/trunk/reviewboard/notifications/models.py
	5 more

/trunk/reviewboard/notifications/admin.py (Diff revision 4)
```
No blank line here.
```
/trunk/reviewboard/notifications/event_manager.py (Diff revision 4)
```
Should only be one blank line.
```

/trunk/reviewboard/notifications/models.py (Diff revision 4)

This will only work for Python 2.6. We need to use django's simplejson otherwise.
 
Though, I don't see this used anywhere.

/trunk/reviewboard/notifications/models.py (Diff revision 4)

This doesn't at all seem tied to the Webhook class.

Would be nice to have a doc block for this.

/trunk/reviewboard/notifications/post_url_dispatcher.py (Diff revision 4)
```
Should be separate imports.
```
/trunk/reviewboard/notifications/post_url_dispatcher.py (Diff revision 4)
```
You should log this instead.
```

/trunk/reviewboard/notifications/post_url_dispatcher.py (Diff revision 4)

Instead of the inline if/else, please do:

if not params:
    params = None

urllib2.urlopen(...)

/trunk/reviewboard/notifications/post_url_dispatcher.py (Diff revision 4)
```
Should also log.
```

/trunk/reviewboard/settings.py (Diff revision 4)

Should be added in the list alphabetically.

/trunk/reviewboard/signals.py (Diff revision 4)

Now that the other change is in, you should update this change.

Change Summary:

    Collapsed all publish signals into one, changed its name and interface.

    Made it look more like the built-in Django signals.

    Fixed formatting errors (according to review).

    Improved formatting for event_source_type in the event payload.

Diff:

Revision 5 (+214 -48)

Show changes

	/trunk/reviewboard/settings.py
	/trunk/reviewboard/signals.py
	/trunk/reviewboard/urls.py
	/trunk/reviewboard/notifications/__init__.py
	/trunk/reviewboard/notifications/admin.py
	/trunk/reviewboard/notifications/email.py
	/trunk/reviewboard/notifications/event_manager.py
	/trunk/reviewboard/notifications/models.py
	5 more

Change Summary:

MOVED.

Description:

	+	MOVED!
	+
	+	This review request is now at: http://reviews.review-board.org/r/993/
	+
	+
	+
		(This is a preliminary code drop; needs more stuff to be ready)
		Allows admin to add multiple webhook URLs. These are dispatched to on publish events, with a payload of the published object and of the changedesc, when available.

		TODO:

		write micro test app using djng to receive POSTs