Fix up some jQuery-related regressions in the admin dashboard.

Review Request #9827 — Created March 22, 2018 and submitted

Information

Review Board
release-4.0.x
946f329...

Reviewers

This fixes up a few regressions that occurred when we updated to jQuery
3.x:

  • $.fn.live(event) no longer exists, in favor of
    $(document).on(event, selector).
  • Some reordering of event handlers made it so that the initial load of
    the news feed was finishing before masonry had been set up. I've added a
    guard to avoid calling reload unless we've done initial set up
    already.
  • The "events" form of $.load no longer exists. I've changed a use of
    it to just use the document ready event.

Loaded the admin site and played around with the dashboard without
seeing any errors pop up in the browser console.

brennie
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (39c87e1)
Loading...